Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Oct 9, 2025

Configurations: 'specification/nginx/Nginx.Management/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: 'aae85aa3e7e4fda95ea2d3abac0ba1d8159db214' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5433741 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=1ac7ac4d-41a4-f011-bbd3-6045bd07ef68 Submitted by: [email protected]

Release Plan Details

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Oct 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure.resourcemanager:azure-resourcemanager-nginx

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for new 2025-03-01-preview API version and TypeSpec-generated models for the NGINX resource manager, introducing WAF policy resources and restructuring serialization/model immutability. Key changes include: (1) introduction of WAF policy clients and models, (2) migration from AutoRest Fluent mutable models to TypeSpec immutable models with altered JSON (de)serialization, (3) updated management client and operations infrastructure.

Reviewed Changes

Copilot reviewed 138 out of 230 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
proxy-config.json Adds new service interfaces for WAF and default WAF policies.
azure-resourcemanager-nginx_metadata.json Registers new generated models and clients for WAF policy features under new API version.
module-info.java Opens additional implementation models package for reflection.
WebApplicationFirewallStatus.java Adds wafRelease field; modifies serialization logic.
OperationDisplay.java Converts to immutable; alters JSON serialization (now empty).
NginxManagementClientImpl.java Reorders constructor parameters and adds new clients (WafPolicies, DefaultWafPolicies); updates API version.
OperationsClientImpl.java Refactors operations listing (sync + async) host parameter name and adds sync LRO helpers.
WafPoliciesImpl.java Implements WAF policy collection operations (list/get/delete/define).
Multiple model classes (e.g., *CompilingStatus, *ApplyingStatus, *ProtectedFileResponse) Converted to @immutable with private constructors; several now serialize empty JSON objects.
Comments suppressed due to low confidence (2)

sdk/nginx/azure-resourcemanager-nginx/src/main/java/com/azure/resourcemanager/nginx/models/NginxConfigurationProtectedFileResponse.java:1

  • Properties virtualPath and contentHash are omitted from serialization, producing unusable JSON for protected file responses. Include both fields in the output.
// Copyright (c) Microsoft Corporation. All rights reserved.

sdk/nginx/azure-resourcemanager-nginx/src/main/java/com/azure/resourcemanager/nginx/models/AnalysisResultData.java:1

  • errors and diagnostics lists are not serialized; callers will see empty JSON preventing downstream tooling from accessing analysis results. Serialize both collections (e.g., jsonWriter.writeArrayField(...)) when non-null.
// Copyright (c) Microsoft Corporation. All rights reserved.


/**
* The object that represents the operation.
* Localized display information for and operation.
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected grammar from 'and operation' to 'an operation'.

Suggested change
* Localized display information for and operation.
* Localized display information for an operation.

Copilot uses AI. Check for mistakes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to fix these in TypeSpec source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants