-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[EngSys] update script to check for external dependency upgrades #35763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 7d26f60.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR re-enables the external dependency upgrade monitoring system by switching from pnpm update --latest
to pnpm outdated --format json --recursive
for better detection of available major version upgrades. The changes improve the accuracy and reliability of dependency upgrade reporting.
Key changes:
- Replaces the previous approach of running updates and parsing git diff output with a more direct method using pnpm's outdated command
- Re-enables GitHub issue creation for dependency upgrades that was previously commented out
- Adds proper JSON parsing and filtering to exclude Azure-internal packages from upgrade reporting
Comments suppressed due to low confidence (1)
eng/scripts/check-external-dependency.ps1:11
- The deprecated dependency regex variable is removed but may still be referenced elsewhere in the codebase. Consider verifying that this variable is not used in other parts of the script or related files.
)
This PR re-enables reporting of available major upgrades for our external dependencies using
pnpm outdated
command.