[EngSys] automatic pnpm update #35771
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
requested review from
mikeharder,
weshaggard,
benbp,
jeremymeng and
a team
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the external dependency checking script to use a more structured approach for detecting outdated packages. The script now uses pnpm outdated with JSON output instead of parsing text output from pnpm update, and enables actual GitHub issue creation for dependency upgrades.
- Switches from regex parsing of
pnpm updateoutput to structured JSON parsing ofpnpm outdatedoutput - Re-enables GitHub issue creation functionality that was previously commented out
- Improves filtering to exclude Azure packages from dependency upgrade tracking
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
eng/scripts/check-external-dependency.ps1:11
- The
$deprecatedDependencyRegexvariable is removed but not replaced with equivalent functionality. The script no longer checks for deprecated dependencies using regex matching, which may miss deprecated packages that aren't flagged in the JSON output.
)
| $availableUpdates = $pnpmOutdatedOutput | ConvertFrom-Json | ||
|
|
||
| foreach ($update in $availableUpdates.PSObject.Properties) { | ||
| if ($update.Name -notmatch '^@azure') { |
There was a problem hiding this comment.
The regex pattern '^@azure' will exclude all packages starting with @azure, but this may be too broad. Consider being more specific (e.g., '^@azure/') to avoid accidentally excluding packages with names that start with 'azure' but aren't Azure SDK packages.
Suggested change
| if ($update.Name -notmatch '^@azure') { | |
| if ($update.Name -notmatch '^@azure/') { |
Copilot uses AI. Check for mistakes.
azure-sdk
force-pushed
the
automated-deps-update
branch
from
f5b5bc8 to
222e9b7
Compare
azure-sdk
force-pushed
the
automated-deps-update
branch
from
222e9b7 to
53ed603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic PR generated weekly with changes from running the command pnpm update