[AutoPR @azure-arm-impactreporting]-generated-from-SDK Generation - JS-5274250 #35801
+2,895
−1,989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l', API Version: 2024-05-01-preview, SDK Release Type: beta, and CommitSHA: 'f9b00d9100abf7a317573f66dcf1fac5ea467b3d' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5274250 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
bot
added
the
Mgmt
praveenkuttappan
requested review from
qiaozha,
MaryGao and
a team
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR is an auto-generated SDK update for the Azure Impact Reporting SDK, updating from an earlier commit to commit f9b00d9100abf7a317573f66dcf1fac5ea467b3d in the Azure REST API specs. The update restructures the codebase to better separate API operations into their own modules and adds new functionality.
- Restructures API operations into separate modules with dedicated
operations.tsandoptions.tsfiles - Adds URL template expansion functionality and cloud setting helpers
- Updates models with new types and reorders export declarations
- Introduces new sample files demonstrating SDK usage
Reviewed Changes
Copilot reviewed 53 out of 55 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
ci.mgmt.yml |
Adds CI pipeline path configuration |
tsp-location.yaml |
Updates commit reference |
static-helpers/ |
Adds new URL template and cloud setting helper utilities |
restorePollerHelpers.ts |
Updates import paths and expected status codes |
models/ |
Major restructuring of model definitions and exports |
api/ |
Refactors API structure into separate operation modules |
classic/ |
Updates classic API wrappers to use new operation imports |
samples-dev/ |
Adds comprehensive sample code files |
sdk/impactreporting/arm-impactreporting/src/static-helpers/urlTemplate.ts
Show resolved
Hide resolved
sdk/impactreporting/arm-impactreporting/src/static-helpers/cloudSettingHelpers.ts
Show resolved
Hide resolved
MaryGao
reviewed
Aug 29, 2025
| ): ImpactContext { | ||
| const endpointUrl = options.endpoint ?? options.baseUrl ?? "https://management.azure.com"; | ||
| const endpointUrl = | ||
| options.endpoint ?? getArmEndpoint(options.cloudSetting) ?? "https://management.azure.com"; |
There was a problem hiding this comment.
@wanlwanl Could you prioritize the issue? It impacts all Modular service release - Azure/azure-sdk-tools#11825
@v-jiaodi the version in below is wrong, please update it manually. you could refer the version in changelog.
const userAgentInfo = `azsdk-js-arm-impactreporting/1.0.0-beta.1`;
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/impact/Impact.Management/tspconfig.yaml', API Version: 2024-05-01-preview, SDK Release Type: beta, and CommitSHA: 'f9b00d9100abf7a317573f66dcf1fac5ea467b3d' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5274250 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Release Plan Details