Repository navigation
Support attached Fabric Spark compute in azure-ai-ml #49501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
93a3b7c
f264f94
1280790
d2bae26
0e1e4d4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| apiMdSha256: c39d5bf8320fae3388fc50ddcd9e5a7cbca070b46ffced33935ae06133a3364e | ||
| apiMdSha256: 4eceeb67e3f43723bec05fb770198bc746d73dd373881d98619979d4fe64393c | ||
| packageVersion: 1.36.0 | ||
| parserVersion: 0.3.31 | ||
| pythonVersion: 3.12.13 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -188,6 +188,8 @@ | |
| EstimatedVMPrice, | ||
| EstimatedVMPrices, | ||
| ExternalFQDNResponse, | ||
| FabricSpark, | ||
| FabricSparkProperties, | ||
| FQDNEndpoint, | ||
| FQDNEndpointDetail, | ||
| FQDNEndpoints, | ||
|
|
@@ -866,6 +868,8 @@ | |
| "EstimatedVMPrice", | ||
| "EstimatedVMPrices", | ||
| "ExternalFQDNResponse", | ||
| "FabricSpark", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As we are adding new type for fabric compute, can you add sample for this in samples folder: https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/ml/azure-ai-ml/samples |
||
| "FabricSparkProperties", | ||
| "FQDNEndpoint", | ||
| "FQDNEndpointDetail", | ||
| "FQDNEndpoints", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| directory: specification/machinelearningservices/MachineLearningServices.Management | ||
| commit: bce80108d7ce39dccc1e9c2df1b1bd99d018bf7f | ||
| directory: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/MachineLearningServices | ||
| commit: 99b98e0bdb68f26290317a5b1ad5e7f6a31cc7e6 | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Confirmed: this source commit is not yet reachable from Azure/azure-rest-api-specs/main. The authoritative FabricSpark contract is in Azure/azure-rest-api-specs#47205, whose published-version Swagger BreakingChange gate is still failing. We cannot replace this pin with a main-reachable commit containing FabricSpark until that upstream PR is approved and merged. I am leaving this thread open rather than claiming the SDK release-validation requirement is met; once the spec lands, I will update the pin to its main-reachable commit, verify the generator contract, and resolve this thread. This comment was generated by an AI assistant on behalf of the PR author. |
||
| repo: Azure/azure-rest-api-specs | ||
| additionalDirectories: [] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # --------------------------------------------------------- | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # --------------------------------------------------------- | ||
|
|
||
| from marshmallow import fields | ||
|
|
||
| from azure.ai.ml.constants._compute import ComputeType | ||
|
|
||
| from ..core.fields import NestedField, StringTransformedEnum | ||
| from .compute import ComputeSchema, IdentitySchema | ||
|
|
||
|
|
||
| class FabricSparkComputeSchema(ComputeSchema): | ||
| type = StringTransformedEnum(allowed_values=[ComputeType.FABRICSPARK], required=True) | ||
| fabric_workspace_id = fields.Str(required=True) | ||
| lakehouse_id = fields.Str(required=True) | ||
| environment_id = fields.Str(required=True) | ||
| pool_id = fields.Str(required=True) | ||
| pool_name = fields.Str(dump_only=True) | ||
| is_attached_compute = fields.Bool(dump_only=True) | ||
| modified_on = fields.Str(dump_only=True) | ||
| disable_local_auth = fields.Bool(dump_only=True) | ||
| identity = NestedField(IdentitySchema) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm that these changes "fabric compute" related do not create regression in existing flows by submitting the samples pipeline: https://dev.azure.com/azure-sdk/internal/_build?definitionId=5066