Skip to content

Run cargo deny check in Analyze job #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Run cargo deny check in Analyze job #2340

wants to merge 4 commits into from

Conversation

heaths
Copy link
Member

@heaths heaths commented Mar 14, 2025

No description provided.

@heaths heaths requested a review from hallipr March 14, 2025 23:31
@heaths
Copy link
Member Author

heaths commented Mar 14, 2025

@hallipr @RickWinter @LarryOsterman this is going to fail until we clean a few more things up. I got rid of some issues - mainly duplicates - when I got rid of http-types, but we still have ring popping up and iron oxide is causing a few dups as well, though it's not the end of the world. We should try to clean up as many possible.

I need to see if BSL-1.0 - the "Boost Software License" - is the same thing as the "Boot Software Code" license mentioned internally. I'll send @ronniegeraghty the internal link to track down.

heaths
heaths commented Mar 14, 2025
View reviewed changes
eng/scripts/Analyze-Code.ps1
@@ -24,6 +25,10 @@ if ($CheckWasm) {
Invoke-LoggedCommand "rustup target add --toolchain $Toolchain wasm32-unknown-unknown"
}

if ($Deny) {
Invoke-LoggedCommand "cargo +$Toolchain install cargo-deny --locked"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hallipr we might actually want to move this out of the script - the install, specifically - so we can take advantage of build caching. Or maybe we can still do that if we collect the right directories in Azure Pipelines. For GitHub Actions, I do this: https://github.com/heaths/template-rustlang/blob/2b23770467f06c59977edfbeea84e96b144a702e/.github/workflows/ci.yml#L37-L45

@heaths heaths linked an issue Mar 20, 2025 that may be closed by this pull request
Run cargo-deny in pipeline to check for violations before CG #2091
Open
@heaths heaths added the EngSys This issue is impacting the engineering system. label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard will be requested when the pull request is marked ready for review weshaggard is a code owner

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter will be requested when the pull request is marked ready for review RickWinter is a code owner

@ronniegeraghty ronniegeraghty Awaiting requested review from ronniegeraghty ronniegeraghty will be requested when the pull request is marked ready for review ronniegeraghty is a code owner

@LarryOsterman LarryOsterman Awaiting requested review from LarryOsterman LarryOsterman will be requested when the pull request is marked ready for review LarryOsterman is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run cargo-deny in pipeline to check for violations before CG
1 participant
@heaths