[Storage] More azure_storage_blob housekeeping (aligning Etag, HttpRange, etc.)#4256
Open
vincenttran-msft wants to merge 7 commits intoAzure:mainfrom
Open
[Storage] More azure_storage_blob housekeeping (aligning Etag, HttpRange, etc.)#4256vincenttran-msft wants to merge 7 commits intoAzure:mainfrom
azure_storage_blob housekeeping (aligning Etag, HttpRange, etc.)#4256vincenttran-msft wants to merge 7 commits intoAzure:mainfrom
Conversation
vincenttran-msft
requested review from
LarryOsterman,
RickWinter,
heaths and
jalauzon-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Housekeeping updates across the Storage crates to improve package metadata and documentation, and to capture an API ergonomics inconsistency around conditional headers (if_match/if_none_match) between blob download and upload options.
Changes:
- Refresh Queue/Blob README formatting and examples (placeholders, example lists, additional Queue send/receive examples).
- Update crate metadata keywords for
azure_storage_queueandazure_storage_blob. - Add a blob test demonstrating
if_matchtype friction between download and upload options; add docs entries for a file-upload example.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure_storage_queue/README.md | README cleanup + adds send/receive code snippets |
| sdk/storage/azure_storage_queue/Cargo.toml | Expands crate keywords metadata |
| sdk/storage/azure_storage_blob/tests/blob_client.rs | Adds test highlighting if_match type inconsistency |
| sdk/storage/azure_storage_blob/examples/README.md | Adds blob_storage_upload_file.rs to example list |
| sdk/storage/azure_storage_blob/README.md | README cleanup, updated examples list + download example |
| sdk/storage/azure_storage_blob/Cargo.toml | Expands crate keywords metadata |
Comments suppressed due to low confidence (1)
sdk/storage/azure_storage_queue/README.md:43
- The README now mentions creating either
QueueClientorQueueServiceClient, but the snippet only showsQueueClient(and doesn’t importQueueServiceClient). This can confuse users who try to follow the text literally; either removeQueueServiceClientfrom this sentence or add a short second snippet showingQueueServiceClient::new(...)usage.
In order to interact with the Azure Queue service, you'll need to create an instance of a client, `QueueClient` or `QueueServiceClient`. The [Azure Identity] library makes it easy to add Microsoft Entra ID support for authenticating Azure SDK clients with their corresponding Azure services:
```rust no_run
use azure_storage_queue::{QueueClient, QueueClientOptions};
use azure_identity::DeveloperToolsCredential;
if_match type discussionazure_storage_blob housekeeping (aligning Etag, HttpRange, etc.)
heaths
approved these changes
Apr 24, 2026
Comment on lines
178
to
200
| /// # Examples | ||
| /// | ||
| /// ``` | ||
| /// use azure_storage_blob::models::HttpRange; | ||
| /// | ||
| /// // Range of 512 bytes starting at offset 0: bytes=0-511 | ||
| /// let range = HttpRange::new(0, 512); | ||
| /// assert_eq!(range.to_string(), "bytes=0-511"); | ||
| /// | ||
| /// // Open-ended range starting at offset 255: bytes=255- | ||
| /// let range = HttpRange::from_offset(255); | ||
| /// assert_eq!(range.to_string(), "bytes=255-"); | ||
| /// | ||
| /// // Convert from standard Rust range types: | ||
| /// let range: HttpRange = (0u64..100).into(); | ||
| /// assert_eq!(range.to_string(), "bytes=0-99"); | ||
| /// | ||
| /// let range: HttpRange = (100u64..).into(); | ||
| /// assert_eq!(range.to_string(), "bytes=100-"); | ||
| /// | ||
| /// let range: HttpRange = (0u64..=99).into(); | ||
| /// assert_eq!(range.to_string(), "bytes=0-99"); | ||
| /// ``` |
Member
There was a problem hiding this comment.
Nit: it's more common to separate these into separate blocks where your code comment would be regular text before the code block, then each acts as a separate tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure/azure-rest-api-specs#42619