Skip to content

Creating an AZSOutputStream from a blob by createOutputStream() causes a crash iOS 7 & 8 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artxj wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Creating an AZSOutputStream from a blob by createOutputStream() causes a crash iOS 7 & 8 #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e6cbe0
Fixed an issue with crash on creating an AZSOutputStream on iOS 7/8.
artxj May 27, 2016
e5f45c6
- iOS 10 remove deprecated asl calls.
artxj Sep 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Lib/Azure Storage Client Library/Azure Storage Client Library/AZSBlobOutputStream.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,8 @@ -(instancetype)initWithURL:(NSURL *)url append:(BOOL)shouldAppend

-(instancetype)initWithAccessCondition:(AZSAccessCondition *)accessCondition requestOptions:(AZSBlobRequestOptions *)requestOptions operationContext:(AZSOperationContext *)operationContext
{
// A designated initializer must make a super call to a designated initializer of the super class.
uint8_t temp;
self = [super initToBuffer:&temp capacity:0];
// A super call to a designated initializer of the super class leads to a crash in iOS 7 or 8.
self = [super init];
if (self)
{
_isStreamOpen = NO;
Expand Down
6 changes: 4 additions & 2 deletions Lib/Azure Storage Client Library/Azure Storage Client Library/AZSOperationContext.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ -(void)logAtLevel:(AZSLogLevel)logLevel withMessage:(NSString *)stringToLog,...
{
return;
}

/*
va_list args;
va_start(args, stringToLog);
NSString *finalLogString;
Expand Down Expand Up @@ -181,6 +181,8 @@ -(void)logAtLevel:(AZSLogLevel)logLevel withMessage:(NSString *)stringToLog,...
}

va_end(args); // Free the memory used for args.

*/
}

-(NSArray *)requestResults
Expand All @@ -193,4 +195,4 @@ -(void)addRequestResult:(AZSRequestResult *)requestResultToAdd
[_requestResults addObject:requestResultToAdd];
}

@end
@end