[.NET] Fix bug where shutting down connectors failed to unsubscribe from device/asset notifications properly #1038
+280
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom device/asset notifications properly The adr client wrapper saved device names as composite device names so, when the client went to break down the composite device names into device name + inbound endpoint name, the inbound endpoint name would always be empty As a result, the ADR service client would repeatedly attempt to unsubscribe with incorrect params This also adds some basic param validation outside of any ADR client retry logic to prevent any param issues from being retried
timtay-microsoft
requested review from
maximsemenov80 and
olivakar
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adr client wrapper saved device names as composite device names so, when the client went to break down the composite device names into device name + inbound endpoint name, the inbound endpoint name would always be empty
As a result, the ADR service client would repeatedly attempt to unsubscribe with incorrect params
This also adds some basic param validation outside of any ADR client retry logic to prevent any param issues from being retried