Add {eventGroupName} as a possible placeholder in connector metadata schema #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtay-microsoft
requested review from
RLeclair,
avishekpant,
cartertinney,
clecompt-msft,
jrdouceur,
maximsemenov80,
olivakar and
vaavva
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds the new placeholder {eventGroupName} to the connector metadata schema documentation.
- Extends supported parameter tokens in three description fields to include {eventGroupName}.
- Does not update the conditional sentence listing when tokens are allowed, leaving {eventGroupName} undocumented in that restriction.
koepalex
reviewed
Oct 20, 2025
| "topic": { | ||
| "type": "string", | ||
| "description": "The default MQTT topic that will be published to. Values are allowed to contain deploy-time parameters like 'mqtt/{deviceName}/{inboundEndpointName}/myMessages'. The supported parameter tokens are: {deviceName}, {inboundEndpointName}, {assetName}, {datasetName}, {eventName}, {streamName}, and {kubernetesNamespace}. Dataset/event/stream name tokens are only allowed if the configured destination is for a dataset/event/stream." | ||
| "description": "The default MQTT topic that will be published to. Values are allowed to contain deploy-time parameters like 'mqtt/{deviceName}/{inboundEndpointName}/myMessages'. The supported parameter tokens are: {deviceName}, {inboundEndpointName}, {assetName}, {datasetName}, {eventGroupName}, {eventName}, {streamName}, and {kubernetesNamespace}. Dataset/eventGroup/event/stream name tokens are only allowed if the configured destination is for a dataset/event/stream." |
Contributor
There was a problem hiding this comment.
Shouldn't we remove eventName as this list also not contain datapointName ?
Member
There was a problem hiding this comment.
I think it would make sense to keep eventName since you can have a destination per event, whereas you can't have a destination per datapoint
Member
Author
There was a problem hiding this comment.
Yeah. Events haven't really changed with the addition of event groups. This list seems correct to me as-is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.