[Rust][Connector] Report endpoint when reporting device #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLeclair
requested review from
avishekpant,
cartertinney and
vaavva
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the inbound endpoint status was excluded from the device status report when the status was not present. The change ensures that the endpoint is always included in the report, even when there is no prior status, maintaining consistency with how endpoint status is reported elsewhere in the code.
- Changed the behavior to always include the inbound endpoint in the status report, mapping it to
Nonewhen no prior status exists
vaavva
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, whenever we reported endpoint we would not report for devices. Due to changes to the service this is now required.