[swsscommon] Add VS tests to swss-common build jobs

[daall]

Signed-off-by: Danny Allen [email protected]

It is possible for changes in swss-common to have unexpected side effects that impact sairedis and swss. The best way to avoid merging such changes is to 1) build sairedis and swss against swss-common, and 2) run the virtual switch tests to make sure that swss-common is still operating as expected with the change.

This PR adds 1) and 2) to the build process for swss-common. This should help avoid merging breaking changes to the swss-common repo and keep the upstream PR tests behaving normally.

Blocked: discussions/testing ongoing.

[daall]

looks like there is an issue: https://sonic-jenkins.westus2.cloudapp.azure.com/job/common/job/jenkins_testing/job/swss-test/17/console

investigating

[judyjoseph]

There is one point here .. So there are intermodular dependencies between sonic-swss and sonic-swss-common now. For eg: redefinition on DBConnector constructor in sonic-swss/tests/mock_tests/mock_dbconnector.cpp.
This could cause a deadlock in commit process into sonic-swss-common. This is because they share the common dbconnector.h file.
@daall We need to consider this before adding this PR build ?

[daall]

There is one point here .. So there are intermodular dependencies between sonic-swss and sonic-swss-common now. For eg: redefinition on DBConnector constructor in sonic-swss/tests/mock_tests/mock_dbconnector.cpp.
This could cause a deadlock in commit process into sonic-swss-common. This is because they share the common dbconnector.h file.
@daall We need to consider this before adding this PR build ?

We do.

I added this check here so that Jenkins can publish the latest swss-common package without the VS tests passing 100%:

sonic-build-tools/jenkins/common/sonic-swss-common-build/Jenkinsfile

Line 58 in 2a0b3f7

catchError(buildResult: 'SUCCESS', stageResult: 'UNSTABLE') {

I'm not sure if this is enough. Let's discuss more tomorrow before going forward with this.