Skip to content

Group members set to null would fail with patch to add members #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Group members set to null would fail with patch to add members #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Microsoft.SystemForCrossDomainIdentityManagement/Protocol/ProtocolExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,11 @@ private static void Apply(this Core2Group group, PatchOperation2 operation)
IList<Member> buffer = new List<Member>();
foreach (Member member in membersToAdd)
{
if(group.Members == null)
{
group.Members = Enumerable.Empty<Member>();
}

//O(n) with the number of group members, so for large groups this is not optimal
if (!group.Members.Any((Member item) =>
string.Equals(item.Value, member.Value, StringComparison.OrdinalIgnoreCase)))
Expand Down