-
Notifications
You must be signed in to change notification settings - Fork 207
ROPC deprecation #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROPC deprecation #855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR deprecates the ROPC (Resource Owner Password Credentials) API across the MSAL Python library by adding deprecation warnings and skipping related tests. The deprecation includes updating documentation, adding warning messages, and providing migration guidance.
- Add deprecation warnings to ROPC-related methods in application.py and main.py
- Skip all ROPC-related tests across multiple test files using @unittest.skip decorator
- Update sample code to log deprecation information
- Remove ROPC function from the interactive CLI menu
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
msal/application.py | Add deprecation warning and updated docstring for acquire_token_by_username_password method |
msal/main.py | Add deprecation warning to ROPC function and remove it from CLI menu |
sample/username_password_sample.py | Add logging message indicating the flow is deprecated |
tests/test_e2e.py | Skip ROPC-related tests with deprecation message |
tests/test_ccs.py | Skip ROPC test method |
tests/test_application.py | Skip ROPC-related test methods |
tests/test_account_source.py | Skip ROPC test method |
tests/broker-test.py | Add unittest import and skip ROPC test function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Bogdan Gavril <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort addressing all the comments!
AB#3385891