Skip to content

Port latest cache create behavior #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renshao wants to merge 1 commit into
base: feature/artifactcache
Choose a base branch
from
Open

Port latest cache create behavior #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/acrcache/azext_acrcache/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,14 @@


from azure.cli.core.util import user_confirmation
from azure.cli.core.commands.client_factory import get_subscription_id
from azure.core.serialization import NULL as AzureCoreNull
from azure.cli.command_modules.acr._utils import get_resource_group_name_by_registry_name, get_registry_by_name
from .vendored_sdks.containerregistry.v2023_11_01_preview.models._models_py3 import CacheRule, ArtifactSyncScopeFilterProperties, CacheRuleUpdateParameters, ImportSource, ImportImageParameters


CREDENTIAL_SET_RESOURCE_ID_TEMPLATE = '/subscriptions/{sub_id}/resourceGroups/{rg}/providers/Microsoft.ContainerRegistry/registries/{reg_name}/credentialSets/{cred_set_name}'

def _create_kql(starts_with=None, ends_with=None, contains=None):
if not starts_with and not ends_with and not contains:
return "Tags"
Expand Down Expand Up @@ -100,10 +103,21 @@ def acr_cache_create(cmd,
dry_run=False,
yes=False):

registry, rg = get_registry_by_name(cmd.cli_ctx, registry_name, resource_group_name)
rg = get_resource_group_name_by_registry_name(cmd.cli_ctx, registry_name, resource_group_name)
if cred_set:
sub_id = get_subscription_id(cmd.cli_ctx)
# Format the credential set ID using subscription ID, resource group, registry name, and credential set name
cred_set_id = CREDENTIAL_SET_RESOURCE_ID_TEMPLATE.format(
sub_id=sub_id,
rg=rg,
reg_name=registry_name,
cred_set_name=cred_set
)
else:
cred_set_id = AzureCoreNull

sync_str = "Active" if sync else "Inactive"
cred_set_id = AzureCoreNull if not cred_set else f'{registry.id}/credentialSets/{cred_set}'

tag = None
if ':' in source_repo:
tag = source_repo.split(':')[1]
Expand Down