Skip to content

feat: add home page#1021

Draft
tmilost wants to merge 16 commits into
masterfrom
feat/home_page
Draft

feat: add home page#1021
tmilost wants to merge 16 commits into
masterfrom
feat/home_page

Conversation

@tmilost
Copy link
Copy Markdown
Member

@tmilost tmilost commented Feb 3, 2026

Negotiator pull request:

Description:

This PR transforms the HomePage from a login screen into an authenticated home page, creating a new LoginPage component to take over the original login functionality. The changes support a clearer separation between public (login) and authenticated (home) views.

Changes:

Created a new LoginPage component that contains the original login UI
Transformed HomePage into an authenticated dashboard displaying user negotiations by role
Added routing changes to support both / (login) and /home (authenticated home)

Checklist:

Make sure you tick all the boxes below if they are true or do not apply before you ask for review

  • I have performed a self-review of my code
  • I have made my code as simple as possible
  • I have added relevant tests for my changes and the code coverage has not dropped substantially
  • I have removed all commented code
  • I have updated the documentation in all relevant places (Javadoc, Swagger, MDs...)
  • I have described the PR and added a meaningful title in the Conventional Commits format

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.39%. Comparing base (1901e50) to head (6f9b9df).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1021   +/-   ##
=========================================
  Coverage     85.39%   85.39%           
  Complexity     2161     2161           
=========================================
  Files           266      266           
  Lines          5999     5999           
  Branches        380      380           
=========================================
  Hits           5123     5123           
  Misses          627      627           
  Partials        249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tmilost tmilost changed the title feat: rename login page component feat: add home page Feb 3, 2026
@tmilost tmilost self-assigned this Feb 3, 2026
@tmilost tmilost added Front-end New feature New feature or request labels Feb 3, 2026
@tmilost tmilost marked this pull request as ready for review February 5, 2026 16:15
Copilot AI review requested due to automatic review settings February 5, 2026 16:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR transforms the HomePage from a login screen into an authenticated home page, creating a new LoginPage component to take over the original login functionality. The changes support a clearer separation between public (login) and authenticated (home) views.

Changes:

  • Created a new LoginPage component that contains the original login UI
  • Transformed HomePage into an authenticated dashboard displaying user negotiations by role
  • Added routing changes to support both / (login) and /home (authenticated home)

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
frontend/src/views/UserPage.vue Added props to support home page mode with limited negotiations display
frontend/src/views/LoginPage.vue New component containing the original login page UI moved from HomePage
frontend/src/views/HomePage.vue Completely refactored to show an authenticated dashboard with user negotiations and discovery services
frontend/src/views/AdminUiConfigurationPage.vue Updated import to use LoginPage instead of HomePage for configuration preview
frontend/src/store/discoveryServices.js New store for fetching discovery services data
frontend/src/router/index.js Updated routes: / now points to LoginPage, added new /home route for HomePage
frontend/src/config/apiPaths.js Added DISCOVERY_SERVICES API path constant
frontend/src/components/ui/buttons/BigButton.vue New button component for navigation panels on home page
frontend/src/components/NegotiationList.vue Added isHomePage prop to conditionally hide search and filters
frontend/src/components/NegotiationCard.vue Added styling improvements with shadow and rounded corners
frontend/src/components/NavigationBar.vue Added "Home" navigation link

Comment thread frontend/src/views/UserPage.vue
Comment thread frontend/src/views/HomePage.vue Outdated
Comment thread frontend/src/store/discoveryServices.js Outdated
Comment thread frontend/src/components/ui/buttons/BigButton.vue Outdated
@tmilost tmilost requested a review from konradlang February 5, 2026 16:25
Comment thread frontend/src/components/ui/buttons/BigButton.vue Outdated
Comment thread frontend/src/components/ui/buttons/BigButton.vue
@RadovanTomik
Copy link
Copy Markdown
Collaborator

Some unstructured feedback from a colleague:

  • Remove the empty circle if there are no Negotiations.
  • Improve the text, idk something. You haven't submitted anything
  • Currently, the page doesn't fit with the design of the rest of the app. For example the icons and buttons are too large compared to the navbar
  • the font is... weird. Especially for the big "Negotiator" title
  • Use requests or negotiations (same problem as in production)
  • why see more if there arent any negotiations?
  • Text aligment
  • Missing Layout... for example the negotiation cards look just pasted/floating there
  • Disocvery services... no explanations on what it is/waht it does
  • See more could be Show More ...
  • Missing colors

@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

@tmilost tmilost marked this pull request as draft March 31, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Front-end New feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants