Skip to content

feat: verify sonar cube token is set before running checks #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stetsche wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: verify sonar cube token is set before running checks #1157

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e4291d
feat: verify sonar cube token is set before running checks
stetsche May 10, 2026
1105d39
fix: limit permissions for token check
stetsche May 11, 2026
2955f34
fix: limit permissions for sonarcube scan
stetsche May 11, 2026
f0a8498
fix: pin sonarcube scan action version
stetsche May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion .github/workflows/sonarqube.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,33 @@ on:
pull_request:
types: [ opened, synchronize, reopened ]
jobs:
check-sonar-token:
name: Check SonarQube token
runs-on: ubuntu-latest
permissions: {}
outputs:
has-sonarqube-token: ${{ steps.check-token.outputs.has-sonarqube-token }}
steps:
- name: Check SonarQube token
id: check-token
env:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
run: |
if [ -n "$SONAR_TOKEN" ]; then
echo "has-sonarqube-token=true" >> "$GITHUB_OUTPUT"
echo "SONAR_TOKEN secret is set."
else
echo "has-sonarqube-token=false" >> "$GITHUB_OUTPUT"
echo "SONAR_TOKEN secret is not set."
Comment thread
stetsche marked this conversation as resolved.
Comment thread
stetsche marked this conversation as resolved.
fi

build:
name: Build and analyze
needs: check-sonar-token
if: ${{ needs.check-sonar-token.outputs.has-sonarqube-token == 'true' }}
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4
with:
Expand Down Expand Up @@ -40,7 +64,7 @@ jobs:
run: mvn -f backend/pom.xml clean verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=BBMRI-ERIC_negotiator -DskipTests=true

- name: Scan Frontend
uses: SonarSource/sonarqube-scan-action@v7
uses: SonarSource/sonarqube-scan-action@c7ee0f9df90b7aa20e8dcf9695dcfe2e7da5b4f2 # v7.2.1
with:
projectBaseDir: frontend
env:
Expand Down
Loading