Skip to content

Basic UI#34

Open
Ajcgd wants to merge 11 commits into
mainfrom
basic-ui
Open

Basic UI#34
Ajcgd wants to merge 11 commits into
mainfrom
basic-ui

Conversation

@Ajcgd
Copy link
Copy Markdown
Contributor

@Ajcgd Ajcgd commented Jul 20, 2025

Negotiator pull request:

Description:

  • this PR adds a basic foundation for a UI interface to manage and control the fhir module functionality
  • the aim is to replace the need to use console for managing the syncs/deletes
  • basic user management together with a draft of monitoring dispaly and sync / delete operations are added

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

  • I have performed a self-review of my code
  • My code follows Google Python Style
  • I have made my code as simple as possible
  • I have added unit tests and the code coverage has not decreased
  • I have updated the documentation in all relevant places

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 87 lines in your changes missing coverage. Please review.

Project coverage is 67.16%. Comparing base (7ef33a0) to head (a484b23).

Files with missing lines Patch % Lines
service/blaze_service.py 0.00% 83 Missing ⚠️
main.py 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (7ef33a0) and HEAD (a484b23). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (7ef33a0) HEAD (a484b23)
unit 6 1
integration 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #34       +/-   ##
===========================================
- Coverage   80.51%   67.16%   -13.35%     
===========================================
  Files          83       83               
  Lines        3869     3941       +72     
===========================================
- Hits         3115     2647      -468     
- Misses        754     1294      +540     
Flag Coverage Δ
integration ?
unit 67.16% <0.00%> (-1.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .github/workflows/build-ui.yml Dismissed
@Ajcgd Ajcgd force-pushed the basic-ui branch 3 times, most recently from 162f046 to a05bc5b Compare August 6, 2025 19:41
@Ajcgd Ajcgd marked this pull request as draft August 17, 2025 18:12
@Ajcgd Ajcgd self-assigned this Aug 24, 2025
@Ajcgd Ajcgd force-pushed the basic-ui branch 2 times, most recently from 3823967 to 6b02764 Compare August 24, 2025 14:54
@Ajcgd Ajcgd requested a review from Copilot September 5, 2025 19:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces a comprehensive web-based user interface for the FHIR module built with Next.js. The UI provides authentication, system monitoring, backend control, and user management capabilities to complement the existing FHIR data synchronization backend.

Key changes:

  • Complete Next.js 15 application with authentication system using NextAuth.js and SQLite database
  • Real-time dashboard with Prometheus integration for system health monitoring
  • Backend control interface for managing FHIR synchronization operations
  • Responsive design with dark/light theme support and accessibility features

Reviewed Changes

Copilot reviewed 99 out of 103 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
ui/fhir-place/* Complete Next.js application with authentication, dashboard, settings, and backend control functionality
docs/UI.md Comprehensive documentation for the UI application including setup, configuration, and deployment
docs/DEPLOYMENT.md Updated deployment documentation to include UI-specific instructions and environment variables
compose.yaml Docker Compose configuration updates to include the UI service and networking
.github/workflows/build-ui.yml CI/CD pipeline for building and publishing the UI Docker container

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread ui/fhir-place/src/hooks/useDeleteDialog.ts Outdated
Comment on lines +43 to +44
return allMessages.map((message) => ({
id: crypto.randomUUID(),
Copy link

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using crypto.randomUUID() in a useMemo dependency can cause performance issues as it generates a new UUID on every render when allMessages changes. Consider using a stable key based on the message content or index instead.

Suggested change
return allMessages.map((message) => ({
id: crypto.randomUUID(),
return allMessages.map((message, idx) => ({
id: `${String(message)}-${idx}`,

Copilot uses AI. Check for mistakes.
Comment thread ui/fhir-place/src/lib/auth.ts Outdated
Comment thread ui/fhir-place/src/lib/seed.ts
Comment thread ui/fhir-place/src/app/(authorized)/backend-control/page.tsx Outdated
import { toast } from "sonner";
import { ConfirmDeleteSchema } from "@/app/(authorized)/backend-control/form/schema";

const deleteAllConfirmMessage = "DELETE ALL";
Copy link

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The hardcoded confirmation message should be moved to a configuration constant or made configurable through props to improve reusability of the hook.

Copilot uses AI. Check for mistakes.
@Ajcgd Ajcgd marked this pull request as ready for review September 6, 2025 11:06
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
13 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Ajcgd Ajcgd requested a review from RadovanTomik September 6, 2025 12:21
@Ajcgd
Copy link
Copy Markdown
Contributor Author

Ajcgd commented Sep 6, 2025

Please see the Sonar suggestions, added comments to some of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants