Skip to content

New ESPAsyncWebserver #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 20, 2025
Merged

New ESPAsyncWebserver #40

merged 5 commits into from
Feb 20, 2025

Conversation

BCsabaEngine
Copy link
Owner

@BCsabaEngine BCsabaEngine commented Feb 20, 2025

Summary by CodeRabbit

  • Documentation

    • Updated changelog and public documentation with version 1.8.0 details, including references and links to the maintained web server library.
  • Chores

    • Upgraded various package and dependency versions.
    • Updated build configurations to reference the new web server repository.
    • Refined linting settings to streamline development.
  • Refactor

    • Simplified backend response handling.
    • Adjusted linting rules to improve code quality.

@BCsabaEngine BCsabaEngine merged commit 3fc155d into main Feb 20, 2025
3 checks passed
@BCsabaEngine BCsabaEngine deleted the feat/esp-async branch February 20, 2025 08:27
Copy link

coderabbitai bot commented Feb 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update introduces version 1.8 with documentation and dependency updates. The CHANGELOG and README now reference the new ESPAsyncWebServer repository and version details. In the PlatformIO configuration, the library source for ESPAsyncWebServer is updated for several environments. ESLint configurations in both the Svelte demo and the root project have been modified to replace the Unicorn plugin string reference with its configuration object and adjust rules. Multiple package.json files have dependency version updates. Finally, the C++ HTTP response handling in src/cppCode.ts now uses beginResponse instead of beginResponse_P.

Changes

Files Summary
CHANGELOG.md Added new version section "1.8" with minor version "1.8.0" and a note on using the maintained ESPAsyncWebServer (new GitHub URL) with some deprecations.
README.md Updated to include the GitHub URL for the current ESPAsyncWebServer and clarified version history and dependency details.
demo/esp32/platformio.ini Updated the lib_deps entry for ESPAsyncWebServer to point to the new repository URL across multiple environments.
ESLint Configs (demo/svelte/eslint.config.mjs, eslint.config.mjs) Replaced 'plugin:unicorn/all' with unicorn.configs.all; removed the unicorn plugin entry; and added the rule 'unicorn/no-nested-ternary': 'off' to refine ESLint configuration.
Package Files (demo/svelte/package.json, package.json) Updated multiple dependency versions including ESLint-related packages, TypeScript, Prettier, Svelte, Vite, and version bump from 1.7.x to 1.8.0 in the root package.json.
src/cppCode.ts Modified HTTP response logic by replacing calls to request->beginResponse_P with request->beginResponse for various conditions (gzip "true", "false", "compiler").

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant HTTP_Handler as HTTP Handler
    participant Request as ESPAsyncWebServer Request

    Client->>HTTP_Handler: Send HTTP Request (with gzip parameter)
    HTTP_Handler->>HTTP_Handler: Evaluate gzip parameter ("true", "false", or "compiler")
    HTTP_Handler->>Request: Call beginResponse (new method)
    Request-->>HTTP_Handler: Return response object
    HTTP_Handler-->>Client: Return HTTP Response
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 24e91e2 and 3429ca4.

⛔ Files ignored due to path filters (6)
  • demo/svelte/dist/assets/index-Bccy-7n-.js is excluded by !**/dist/**
  • demo/svelte/dist/assets/index-DSjEOBdh.js is excluded by !**/dist/**
  • demo/svelte/dist/favicon.png.gz is excluded by !**/dist/**, !**/*.gz
  • demo/svelte/dist/index.html is excluded by !**/dist/**
  • demo/svelte/package-lock.json is excluded by !**/package-lock.json
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (8)
  • CHANGELOG.md (1 hunks)
  • README.md (2 hunks)
  • demo/esp32/platformio.ini (1 hunks)
  • demo/svelte/eslint.config.mjs (1 hunks)
  • demo/svelte/package.json (1 hunks)
  • eslint.config.mjs (2 hunks)
  • package.json (2 hunks)
  • src/cppCode.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant