Skip to content

Fixing Infer Radius Method #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Fixing Infer Radius Method #153

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
fd84030
Currently, the checking infer_from loop is not properly preferring th…
SherelynA Mar 21, 2025
6911257
outline of a test
kelle Mar 24, 2025
7bd4dec
Changed rounding in the dwarf sequence relations because if not it wo…
SherelynA Mar 31, 2025
73f3651
Tried calling two different fixtures, one where we use substellar uni…
SherelynA Mar 31, 2025
cb31395
remove radius tests from just_spectrum
kelle Mar 31, 2025
c91504b
add results to paramaterization
kelle Mar 31, 2025
4a3e2a3
Merge pull request #1 from kelle/radius-fix-kelle
SherelynA Apr 2, 2025
61940e2
Tests work now, but when I run the final test_radius on my console, e…
SherelynA Apr 2, 2025
82b77cb
getting rid of the radius rounding in the relations.py.
SherelynA May 27, 2025
82cffb4
Update tests/test_fundamental_params.py
SherelynA May 27, 2025
5c99a21
Merge remote-tracking branch 'origin/infer_radius_fix' into infer_rad…
SherelynA May 27, 2025
85d7b08
gettind rid of rounding for the values
SherelynA May 28, 2025
5aaf638
cleaning code up from print statements used during testing. Added dif…
SherelynA Jun 3, 2025
c0a893d
I changed the formation of the evaluate funciton in relations.py to u…
SherelynA Jun 3, 2025
3f14fc5
Adding age distribution as a static paramter that can be passed to th…
SherelynA Jun 3, 2025
a2e9581
Adding the age distribution paramter in the instances of evaluation t…
SherelynA Jun 3, 2025
b0daa0d
Taking into account the type of distribution for the age in the evalu…
SherelynA Jun 3, 2025
7787109
tweaking some portion of the age distribution setter
SherelynA Jun 3, 2025
db0b058
got rid of the float in the formatting because it was adding a traili…
SherelynA Jun 6, 2025
790ba97
Fixing spacing in the new code for a normal distribution.
SherelynA Jun 6, 2025
6090e9f
Add code which checks for the age distribution when it calculates the…
SherelynA Jun 6, 2025
34c6ac5
getting rid of random print statements
SherelynA Jun 6, 2025
2c32741
changing the test to have a larger age range and adjusting assert sta…
SherelynA Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sedkit/relations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ def evaluate(self, rel_name, x_val, xunits=None, yunits=None, fit_local=False, p
self.relations[rel_name] = full_rel

if y_upper is not None:
return y_val, y_upper, y_lower, self.ref
return y_val.round(3), y_upper.round(3), y_lower.round(3), self.ref
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you should round these values. instead, I think you should consider using %g formatting when displaying it to the user.
Check out the examples here: https://stackoverflow.com/a/3411731/4842634

else:
return y_val, self.ref

Expand Down
Loading
Loading