Update movie of the laser spectrum for staging_injector
#271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
changed the title
staging_injector
Member
|
If the new function is available only in a specific branch of openPMD-viewer, do we have to update a dependency somewhere? I don't remember if we have a simulation environment configured besides the dashboard environment. |
Contributor
Author
|
We don't have a simulation environment file yet. |
EZoni
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the calculation of the laser spectrum.
Instead of using the function
get_spectrum-- which computes the FFT of the on-axis electric field -- this uses the functionget_laser_spectral_intensity(from this branch of openPMD-viewer -- which computes the spectrum of the full laser (not only an on-axis slice)