Skip to content

Link analysis_default_regression.py for pierce diode test - #6810

Merged
RemiLehe merged 1 commit into
BLAST-WarpX:developmentfrom
EZoni:pierce_diod_analysis_default_regression
Apr 28, 2026
Merged

RemiLehe merged 1 commit into
BLAST-WarpX:developmentfrom
EZoni:pierce_diod_analysis_default_regression

Conversation

@EZoni

@EZoni EZoni commented Apr 27, 2026 •

Copy link
Copy Markdown
Member

Overview

The file analysis_default_regression.py in the directory of the pierce diode test, originally added in #5999, is a hard copy but should be a link, as described in our documentation at warpx.readthedocs.io/en/latest/developers/how_to_test.html#how-to-add-automated-tests:

  1. If the test directory is new, make a symbolic link to the default regression analysis script analysis_default_regression.py from Examples/analysis_default_regression.py, by running ln -s ../../analysis_default_regression.py analysis_default_regression.py from the test directory.

This was observed in #6801 (comment).

Related PRs

@EZoni
EZoni requested review from RemiLehe and oshapoval April 27, 2026 18:21
@EZoni EZoni added bug Something isn't working component: tests CI/CD tests bug: affects latest release Bug also exists in latest release version labels Apr 27, 2026
@EZoni
EZoni requested a review from ax3l April 27, 2026 18:22

@lucafedeli88 lucafedeli88 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @EZoni

@RemiLehe
RemiLehe merged commit a149209 into BLAST-WarpX:development Apr 28, 2026
47 of 48 checks passed
ax3l pushed a commit that referenced this pull request Jul 8, 2026
## Overview

Add a CI job to check that `analysis_default_regression.py` in
`Examples/Tests/` or `Examples/Physics_applications/` is always a link,
not a hard copy, to prevent errors such as the one fixed in #6810.

<img width="2024" height="932" alt="Screenshot from 2026-04-27 11-51-50"
src="https://github.com/user-attachments/assets/50526642-faea-4823-b5f5-b37a2f9275fa"
/>

## To do

- [x] Merge #6810 and rebase.
aeriforme pushed a commit to pkicsiny/WarpX that referenced this pull request Aug 13, 2026
…X#6810)

## Overview

The file `analysis_default_regression.py` in the directory of the pierce
diode test, originally added in BLAST-WarpX#5999, is a hard copy but should be a
link, as described in our documentation at
[warpx.readthedocs.io/en/latest/developers/how_to_test.html#how-to-add-automated-tests](https://warpx.readthedocs.io/en/latest/developers/how_to_test.html#how-to-add-automated-tests):

> 6. If the test directory is new, make a symbolic link to the default
regression analysis script analysis_default_regression.py from
[Examples/analysis_default_regression.py](https://github.com/BLAST-WarpX/warpx/blob/development/Examples/analysis_default_regression.py),
by running `ln -s ../../analysis_default_regression.py
analysis_default_regression.py` from the test directory.

This was observed in
BLAST-WarpX#6801 (comment).

## Related PRs

- BLAST-WarpX#6811
aeriforme pushed a commit to pkicsiny/WarpX that referenced this pull request Aug 13, 2026
…-WarpX#6811)

## Overview

Add a CI job to check that `analysis_default_regression.py` in
`Examples/Tests/` or `Examples/Physics_applications/` is always a link,
not a hard copy, to prevent errors such as the one fixed in BLAST-WarpX#6810.

<img width="2024" height="932" alt="Screenshot from 2026-04-27 11-51-50"
src="https://github.com/user-attachments/assets/50526642-faea-4823-b5f5-b37a2f9275fa"
/>

## To do

- [x] Merge BLAST-WarpX#6810 and rebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: affects latest release Bug also exists in latest release version bug Something isn't working component: tests CI/CD tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants