Fix silent failure in analysis_default_regression.py#6812
Merged
lucafedeli88 merged 1 commit intoBLAST-WarpX:developmentfrom Apr 28, 2026
Merged
Conversation
EZoni
added
bug
ax3l
pushed a commit
that referenced
this pull request
Apr 28, 2026
## Overview Follow up on #6812 and clean up the code that handles the detection of the output format in the default regression analysis script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This fixes a silent failure on format detection in analysis_default_regression.py. If both
ytandopenPMDattempts fail, the code printed a message but continued execution. Depending on what follows, this could lead to a confusing downstream error or silent misbehavior.The issue came up in #6801 (comment) as part of #6801.
Notes
I added a few empty lines to improve readability as well.