Test vcpkg test failure #6706

AenBleidd · 2025-11-27T08:50:14Z

Summary by cubic

Update the x86-linux job to bump apt mirror priority, enable Ubuntu repositories (main, universe, restricted, multiverse), add the Ubuntu Toolchain PPA, add Debian bookworm main, and install g++-i686-linux-gnu along with g++-multilib and gcc-multilib to enforce 32-bit builds during vcpkg test configuration. Also clone vcpkg from AenBleidd/vcpkg and checkout vko_fix_x86-linux_build to test the fix and consistently reproduce the vcpkg test failure.

^{Written for commit dfb9c7e. Summary will update automatically on new commits.}

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot

Pull request overview

This PR pins vcpkg to a specific commit (9aee6e968f51e15ee93606f064691d8f6d228190) in response to a test failure. The change adds a git checkout command to lock vcpkg to a known working version for the Linux build job.

Key Changes:

Adds vcpkg commit pinning to the Linux job's vcpkg setup step

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-27T08:54:36Z

.github/workflows/vcpkg_test.yml

        - name: Set up vcpkg
          run: |
            git clone https://github.com/microsoft/vcpkg.git
+            git -C vcpkg checkout 9aee6e968f51e15ee93606f064691d8f6d228190


The vcpkg commit is pinned only for the Linux job. This creates inconsistency across different build jobs (android, macos, mingw, windows), which will use different versions of vcpkg. If this commit is needed to fix a test failure, it should be applied to all jobs that set up vcpkg (lines 86-89, 330-333, 388-391, and 447-450) to ensure consistent behavior across all platforms.

Suggested change

git -C vcpkg checkout 9aee6e968f51e15ee93606f064691d8f6d228190

git -C vcpkg checkout 9aee6e968f51e15ee93606f064691d8f6d228190

git -C vcpkg checkout 9aee6e968f51e15ee93606f064691d8f6d228190

git -C vcpkg checkout 9aee6e968f51e15ee93606f064691d8f6d228190

git -C vcpkg checkout 9aee6e968f51e15ee93606f064691d8f6d228190

git -C vcpkg checkout 9aee6e968f51e15ee93606f064691d8f6d228190

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-27T09:28:07Z

.github/workflows/vcpkg_test.yml

        - name: Set up vcpkg
          run: |
            git clone https://github.com/microsoft/vcpkg.git
+            git -C vcpkg checkout c70c929e4854f1add688dab6abd5e0f466864767


The vcpkg revision is only pinned in the Linux job, but other jobs (android, macos, mingw, windows) still clone vcpkg without pinning to this specific revision. This creates inconsistency where different jobs may use different vcpkg versions. If the goal is to reproduce a test failure or ensure deterministic builds, all jobs should pin to the same vcpkg revision.

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-27T10:14:04Z

.github/workflows/vcpkg_test.yml

          run: |
            sudo apt-get update
-            sudo apt-get install -y g++-multilib gcc-multilib
+            sudo apt-get install -y crossbuild-essential-i386


The package crossbuild-essential-i386 is designed for cross-compilation from amd64 to i386, but the x86 build configuration (line 286) uses gcc -m32 and g++ -m32 instead of cross-compilation toolchain commands like i686-linux-gnu-gcc. This is inconsistent with the ARM builds which install cross-compilation packages and use triplet-prefixed compilers.

If multilib compilation is the intent (using -m32 flags), consider using gcc-multilib g++-multilib as done in .github/workflows/linux.yml:400. If cross-compilation is the intent, update the build configuration to use i686-linux-gnu-gcc and i686-linux-gnu-g++.

Suggested change

sudo apt-get install -y crossbuild-essential-i386

sudo apt-get install -y gcc-multilib g++-multilib

Copilot · 2025-11-27T10:14:04Z

.github/workflows/vcpkg_test.yml

          run: |
            sudo apt-get update
-            sudo apt-get install -y g++-multilib gcc-multilib
+            sudo apt-get install -y crossbuild-essential-i386


The PR description mentions "Pin vcpkg to a specific revision in the CI workflow to reproduce and isolate the vcpkg test failure" but the actual change replaces x86 dependency packages. The description doesn't match the code change. Please update the PR description to accurately reflect that this changes x86 build dependencies.

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-05T04:57:28Z

.github/workflows/vcpkg_test.yml

+            sudo sed -i 's|priority:1|priority:100|' /etc/apt/apt-mirrors.txt
            sudo apt-get update
-            sudo apt-get install -y g++-multilib gcc-multilib
+            sudo apt-get install -y g++-multilib gcc-multilib g++-i686-linux-gnu


The PR description mentions installing gcc-i686-linux-gnu and binutils-i686-linux-gnu to "enforce 32-bit builds," but the actual code only adds g++-i686-linux-gnu. The gcc-i686-linux-gnu and binutils-i686-linux-gnu packages mentioned in the PR description are missing.

For consistency with the arm and arm64 dependency installations (lines 237 and 243), which install all three components (g++, gcc, and binutils), consider adding the missing packages:

sudo apt-get install -y g++-multilib gcc-multilib g++-i686-linux-gnu gcc-i686-linux-gnu binutils-i686-linux-gnu

Suggested change

sudo apt-get install -y g++-multilib gcc-multilib g++-i686-linux-gnu

sudo apt-get install -y g++-multilib gcc-multilib g++-i686-linux-gnu gcc-i686-linux-gnu binutils-i686-linux-gnu

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-05T12:34:41Z

.github/workflows/vcpkg_test.yml

+            sudo apt-add-repository main
+            sudo apt-add-repository restricted
+            sudo apt-add-repository multiverse


[nitpick] Adding main, restricted, and multiverse repositories individually is unusual. These Ubuntu repository components are typically already available in the default sources.list. Based on the pattern used in other workflow files (android.yml lines 52, 206), only the universe component typically needs to be added explicitly. Consider simplifying this to just sudo add-apt-repository universe unless there's a specific need for the other components.

Suggested change

sudo apt-add-repository main

sudo apt-add-repository restricted

sudo apt-add-repository multiverse

Copilot · 2025-12-05T12:34:42Z

.github/workflows/vcpkg_test.yml

+            sudo apt-add-repository universe
+            sudo apt-add-repository main
+            sudo apt-add-repository restricted
+            sudo apt-add-repository multiverse


Inconsistent command usage: apt-add-repository should be add-apt-repository to match the standard Ubuntu command and the pattern used elsewhere in this file (line 234) and other workflow files (e.g., android.yml lines 52, 206). The correct command is add-apt-repository.

Suggested change

sudo apt-add-repository universe

sudo apt-add-repository main

sudo apt-add-repository restricted

sudo apt-add-repository multiverse

sudo add-apt-repository universe

sudo add-apt-repository main

sudo add-apt-repository restricted

sudo add-apt-repository multiverse

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Vitalii Koshura <[email protected]>

Test vcpkg test failure

5c0ab42

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot AI review requested due to automatic review settings November 27, 2025 08:50

Copilot started reviewing on behalf of AenBleidd November 27, 2025 08:53 View session

Copilot finished reviewing on behalf of AenBleidd November 27, 2025 08:53

Copilot AI reviewed Nov 27, 2025

View reviewed changes

AenBleidd added 2 commits November 27, 2025 10:02

Add another revision

1f331a8

Signed-off-by: Vitalii Koshura <[email protected]>

Another revision

8a35aac

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot AI review requested due to automatic review settings November 27, 2025 09:19

Copilot started reviewing on behalf of AenBleidd November 27, 2025 09:25 View session

Copilot finished reviewing on behalf of AenBleidd November 27, 2025 09:26

Copilot AI reviewed Nov 27, 2025

View reviewed changes

AenBleidd added 2 commits November 27, 2025 10:38

Another revision

c7a1f84

Signed-off-by: Vitalii Koshura <[email protected]>

Try with the other package installed

a566bbd

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot AI review requested due to automatic review settings November 27, 2025 10:05

Copilot started reviewing on behalf of AenBleidd November 27, 2025 10:11 View session

Copilot finished reviewing on behalf of AenBleidd November 27, 2025 10:11

Copilot AI reviewed Nov 27, 2025

View reviewed changes

AenBleidd added 2 commits November 27, 2025 11:18

Another try

f652010

Signed-off-by: Vitalii Koshura <[email protected]>

Another try

86dc639

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot AI review requested due to automatic review settings November 27, 2025 10:34

Copilot started reviewing on behalf of AenBleidd November 27, 2025 10:34 View session

Copilot finished reviewing on behalf of AenBleidd November 27, 2025 10:36

Copilot AI reviewed Nov 27, 2025

View reviewed changes

AenBleidd added 2 commits November 27, 2025 11:41

Another try

6114b51

Signed-off-by: Vitalii Koshura <[email protected]>

One more try

ff728c0

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot AI review requested due to automatic review settings November 27, 2025 10:50

AenBleidd added 2 commits November 27, 2025 11:53

One more try

ca235ba

Signed-off-by: Vitalii Koshura <[email protected]>

Try temporary fix

bf8307f

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot AI reviewed Nov 27, 2025

View reviewed changes

Another shoot

3123dae

Signed-off-by: Vitalii Koshura <[email protected]>

Another try

47e6399

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot AI review requested due to automatic review settings December 5, 2025 04:50

Copilot started reviewing on behalf of AenBleidd December 5, 2025 04:52 View session

Copilot finished reviewing on behalf of AenBleidd December 5, 2025 04:53

Copilot AI reviewed Dec 5, 2025

View reviewed changes

AenBleidd added 2 commits December 5, 2025 13:16

Try fix dependencies

9d08249

Signed-off-by: Vitalii Koshura <[email protected]>

Try fix dependencies

14523b4

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot AI review requested due to automatic review settings December 5, 2025 12:28

Copilot started reviewing on behalf of AenBleidd December 5, 2025 12:31 View session

Copilot finished reviewing on behalf of AenBleidd December 5, 2025 12:32

Copilot AI reviewed Dec 5, 2025

View reviewed changes

Try fix dependencies

8125700

Signed-off-by: Vitalii Koshura <[email protected]>

Copilot AI review requested due to automatic review settings December 5, 2025 22:54

Copilot started reviewing on behalf of AenBleidd December 5, 2025 22:56 View session

Copilot AI reviewed Dec 5, 2025

View reviewed changes

Test vcpkg fix

dfb9c7e

Signed-off-by: Vitalii Koshura <[email protected]>

AenBleidd force-pushed the vko_debug_vcpkg_test_fail branch from 4ce2a0f to dfb9c7e Compare December 5, 2025 23:13

	sudo apt-get install -y crossbuild-essential-i386
	sudo apt-get install -y gcc-multilib g++-multilib

	sudo apt-get install -y g++-multilib gcc-multilib g++-i686-linux-gnu
	sudo apt-get install -y g++-multilib gcc-multilib g++-i686-linux-gnu gcc-i686-linux-gnu binutils-i686-linux-gnu

	sudo apt-add-repository main
	sudo apt-add-repository restricted
	sudo apt-add-repository multiverse

Test vcpkg test failure #6706

Are you sure you want to change the base?

Test vcpkg test failure #6706

Conversation

AenBleidd commented Nov 27, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

AenBleidd commented Nov 27, 2025 •

edited by cubic-dev-ai bot

Loading