Skip to content

[NPE] Particles noise #17500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 2, 2025
Merged

[NPE] Particles noise #17500

merged 10 commits into from
Dec 2, 2025
+262 −52

Conversation

@VicenteCartas
Copy link
Contributor

@VicenteCartas VicenteCartas commented Nov 22, 2025 •
edited
Loading

  • Adds a new UpdateNoiseBlock to support migrating noise from old system to NPE.
  • Minor changes required to handle a ProceduralTexture.
  • Resets particle randomNoiseCoordinates1 and 2.

PG to test: #R1JWLA#151
image

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

Snapshot stored with reference name:
refs/pull/17500/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17500/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17500/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/17500/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17500/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17500/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17500/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17500/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17500/merge/testResults/interactionplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17500/merge/testResults/devhostplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17500/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17500/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17500/merge/testResults/interactionplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17500/merge/testResults/devhostplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17500/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17500/merge/testResults/webgl2playwright/index.html

@VicenteCartas VicenteCartas marked this pull request as ready for review December 2, 2025 00:28
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 2, 2025

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17500/merge/testResults/interactionplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 2, 2025

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17500/merge/testResults/devhostplaywright/index.html

@deltakosh deltakosh enabled auto-merge (squash) December 2, 2025 00:58
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 2, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17500/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 2, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17500/merge/testResults/webgpuplaywright/index.html

@deltakosh deltakosh merged commit fda5c8c into BabylonJS:master Dec 2, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deltakosh deltakosh deltakosh approved these changes

Assignees

No one assigned

Labels

enhancement npe

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VicenteCartas @bjsplat @deltakosh