-
Notifications
You must be signed in to change notification settings - Fork 65
New NPM #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CedricGuillemet
wants to merge
367
commits into
BabylonJS:master
Choose a base branch
from
CedricGuillemet:NewNPM
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New NPM #665
+37,124
−374,926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2025
@ryantrem Now using cmake-runtime. Its use will appear in the log : |
ryantrem
reviewed
Jul 16, 2025
ryantrem
reviewed
Jul 16, 2025
ryantrem
reviewed
Jul 16, 2025
ryantrem
reviewed
Jul 16, 2025
CedricGuillemet
added a commit
to BabylonJS/BabylonNative
that referenced
this pull request
Jul 17, 2025
related to BabylonJS/BabylonReactNative#665 Some dependencies are fetched only for the platform being built. `BABYLON_NATIVE_BUILD_SOURCETREE` variable has been added to allow fetching independently of active platform. --------- Co-authored-by: Drew Fillebrown <[email protected]>
This reverts commit e70834c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Goal
Deliver 1 single self contained package with sources (no fetch, no secondary download) for all platform, for all RN versions.
Deprecated existing (Playground, tests, build script) in favor of a single RNTA Playground and simpler tooling.
Building the new NPM
Testing
PR Changes
react-native-iosandroid
andreact-native-windows
content intoModules/@babylonjs/react-native
folderbuildBabylonNativeSourceTree
gulp export to gather BN sourcesTODO
BABYLON_NATIVE_PLUGIN_NATIVECAMERA=0
,BABYLON_NATIVE_PLUGIN_NATIVEXR=0
)- [ ] Script to change RN version for RNTALeft to users to get a working node environmentissue with RN 0.78. fixed with RN 0.80. not tested with previous versions. To fix (if it happens) on user side.
Notes:
Pros/Cons of sources in package
Pros
BASE_KIT
package)Cons
Sizes
Binary packages
TS : 23Kb
Windows: 102Mb (700Mb Unzipped)
iOS-Android: 21Mb (65Mb Unzipped)
Source package
13Mb (74Mb Unzipped)