Skip to content

BAH-4504 Add support for additional section on registration create patient page #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hamsavarthiniR-Bahmni wants to merge 5 commits into
base: master
Choose a base branch
from
+54 −4
Open

BAH-4504 Add support for additional section on registration create patient page #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2159a3
BAH-4504 Add support for additional section on registration create pa…
hamsavarthiniR-Bahmni Mar 17, 2026
19457f6
BAH-4504|Add. Locales and Configs
Varun-beta Mar 20, 2026
d7dd194
BAH-4504 Remove the flag showExtraPatientIdentifiersSection
hamsavarthiniR-Bahmni Mar 20, 2026
f640bf1
BAH-4504|Update config , since profile is hardcoded in frontend
Varun-beta Apr 1, 2026
073ce72
BAH-4504|Fix. Review Comments
Varun-beta Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 42 additions & 2 deletions openmrs/apps/registration/v2/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,48 @@
"translationKey": "REGISTRATION_ALTERNATE_PHONE_NUMBER"
}
]
},
"showExtraPatientIdentifiersSection": true
}
},
"registrationForm": {
"sections": [
{
"name": "Address Information",
"translationKey": "REGISTRATION_SECTION_ADDRESS_DETAILS",
"controls": [
{
"type": "address"
}
]
},
{
"name": "Contact Information",
"translationKey": "REGISTRATION_SECTION_CONTACT_DETAILS",
"controls": [
{
"type": "contactInfo"
}
]
},
Copy link
Copy Markdown

@PratitiP PratitiP Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fields on the respective sections looks little bit scattered. We need to look into patientInformation section to check which fields are there in the additionalInfo.
As discussed we can take this in upcoming cards. Also we should consider a scenario, where we might need multiple additional information sections. So which fields go in which additional info sections should be coupled some how

{
"name": "Additional Information",
"translationKey": "REGISTRATION_SECTION_ADDITIONAL_INFO",
"controls": [
{
"type": "additionalInfo"
}
]
},
{
"name": "Identifiers",
"translationKey": "REGISTRATION_SECTION_IDENTIFIERS",
"controls": [{ "type": "additionalIdentifiers" }]
},
{
"name": "Relationships",
"translationKey": "REGISTRATION_SECTION_RELATIONSHIPS",
"controls": [{ "type": "relationships" }]
}
]
},
"fieldValidation": {
"firstName": {
Expand Down
7 changes: 6 additions & 1 deletion openmrs/i18n/registration/locale_en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,10 @@
"REGISTRATION_LAST_NAME_VALIDATION": "Last name should contain only alphabets without space",
"REGISTRATION_EMAIL_VALIDATION": "Should be a valid email address",
"REGISTRATION_PHONE_NUMBER_VALIDATION": "Phone number should be numbers between 6 to 15 digits",
"REGISTRATION_ALTERNATE_PHONE_NUMBER_VALIDATION": "Alternate phone number should be numbers between 6 to 15 digits"
"REGISTRATION_ALTERNATE_PHONE_NUMBER_VALIDATION": "Alternate phone number should be numbers between 6 to 15 digits",
"REGISTRATION_SECTION_ADDRESS_DETAILS": "Address information",
"REGISTRATION_SECTION_CONTACT_DETAILS": "Contact information",
"REGISTRATION_SECTION_ADDITIONAL_INFO": "Additional information",
"REGISTRATION_SECTION_IDENTIFIERS": "Additional identifiers",
"REGISTRATION_SECTION_RELATIONSHIPS": "Relationship information"
}
7 changes: 6 additions & 1 deletion openmrs/i18n/registration/locale_es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,10 @@
"REGISTRATION_LAST_NAME_VALIDATION": "El apellido debe contener solo letras sin espacios",
"REGISTRATION_EMAIL_VALIDATION": "Debe ser una dirección de correo electrónico válida",
"REGISTRATION_PHONE_NUMBER_VALIDATION": "El número de teléfono debe tener entre 6 y 15 dígitos",
"REGISTRATION_ALTERNATE_PHONE_NUMBER_VALIDATION": "El número de teléfono alternativo debe tener entre 6 y 15 dígitos"
"REGISTRATION_ALTERNATE_PHONE_NUMBER_VALIDATION": "El número de teléfono alternativo debe tener entre 6 y 15 dígitos",
"REGISTRATION_SECTION_ADDRESS_DETAILS": "Información de dirección",
"REGISTRATION_SECTION_CONTACT_DETAILS": "Información de contacto",
"REGISTRATION_SECTION_ADDITIONAL_INFO": "Información adicional",
"REGISTRATION_SECTION_IDENTIFIERS": "Identificadores adicionales",
"REGISTRATION_SECTION_RELATIONSHIPS": "Información de relación"
}