fix(dev-harness): resolve canonical Python venv - #10017
Conversation
Failure-Class: none
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b26150e6ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Monitor summary — Codex P2 "Preserve shell quoting for resolved Python" Addressed by the existing head commit
Verification (in the monitor worktree, rebased onto
Thread |
kodjima33
left a comment
There was a problem hiding this comment.
Dev-harness venv resolution fix. Approve-only (tooling).
Summary
PYTHON, thenbackend/.venv/bin/python, legacybackend/venv/bin/python, thenpython3.dev-initcreates the canonical.venvwhen neither venv exists.Root cause and durable guard
Harness commands and Makefile targets had inconsistent hard-coded legacy
backend/venvdefaults. A single resolver owns precedence now, with a hermetic regression test covering every selection branch.Verification
/Users/dazheng/workspace/omi/backend/.venv/bin/python -m pytest -q scripts/dev-harness/tests/test_python_resolver.py— 2 passedbash -nfor the resolver plus all 9 harness consumers — passgit diff --cached --check— passmake preflight— passed (9 deterministic checks)Failure-Class
Failure-Class: none