fix: surface silent failures across agent, auth, and desktop#10081
fix: surface silent failures across agent, auth, and desktop#10081undivisible wants to merge 2 commits into
Conversation
Failure-Class: none
Agent VM recovery no longer discards Firestore/GCE errors as success, and custom-token requests fail closed instead of returning a partial token payload. Also remove the unused memories evidence placeholder and log Electron retention/token/screen failure paths that previously looked healthy when they were not. Verification: - cargo check --manifest-path desktop/macos/Backend-Rust/Cargo.toml --bin omi-desktop-backend - cargo test --manifest-path desktop/macos/Backend-Rust/Cargo.toml --bin omi-desktop-backend agent --offline - python3 ast-parse backend/database/memories.py Failure-Class: none Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Hey @undivisible 👋 Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request. After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:
Before your next PR, please skim:
If this was declined for direction or taste, maintainers should cite an invariant ID or open a proposed one — ask if that citation is missing. Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out. Thank you for being part of the Omi community! |
|
Superseded by #10084 after renaming the branch to |
What changed and why
Stops fail-open and silent-failure paths on the current (non-Tauri) desktop/backend stack so errors surface instead of looking healthy.
use_custom_token=truereturns an error instead of a partial token payload when minting is unimplemented.recompute_evidenceplaceholder (no callers).catch {}.Product invariants affected
How it was verified
cargo check --manifest-path desktop/macos/Backend-Rust/Cargo.toml --bin omi-desktop-backend— passedcargo test --manifest-path desktop/macos/Backend-Rust/Cargo.toml --bin omi-desktop-backend agent --offline— passedpython3AST parse ofbackend/database/memories.py— passedscripts/pr-preflight— 26 checks passedno-changelog-needed(internal logging / reliability only)Tests
No focused route test exists for the GCE/Firestore recovery path; the existing backend binary agent test passed. Electron changes are log-only on already-handled error paths.
Failure class (fixes)
Failure-Class: none