fix(desktop): harden Notch chat and PTT reliability#10125
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fa35e6f41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep user-resized Notch chat dimensions stable across macOS Space changes and stop streaming output from reclaiming an intentionally scrolled viewport. Failure-Class: none
Failure-Class: none
Failure-Class: none
Failure-Class: none
Failure-Class: none
Git-on-my-level
force-pushed
the
codex/fix-notch-chat-stability
branch
from
July 20, 2026 19:43
fbc4b65 to
a86663e
Compare
Failure-Class: none
Failure-Class: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Product invariants
Verification
desktop/macos/scripts/agent-logic-harness.sh— passed (Swift lifecycle, agent runtime, and pi extension suites)xcrun swift test --package-path Desktop --filter ChatSkillCatalogTests— passed (2 tests)xcrun swift test --package-path Desktop --filter AgentPillLifecycleTests/testFloatingAgentToolCallsUseCompactOneLinePresentation— passednpm run buildandnode --experimental-strip-types scripts/generate-tool-surfaces.mjs --checkindesktop/macos/agent— passednpx vitest run tests/node-tools.test.ts tests/omi-tool-manifest.test.ts— passed (20 tests)npx --yes tsx --test index.test.tsindesktop/macos/pi-mono-extension— passedmake preflightand the bounded pre-push gate — passedgit diff --check— passed/Applications/omi-tool-stall-reliability.appfromae2e79f; health check confirmed development backend and agent protocol 2, and automation confirmed Chat's Home button returns to the dashboardxcrun swift test --package-path Desktop --filter ScreenRecordingPermissionPolicyTests— passed (15 tests)xcrun swift test --package-path Desktop --filter RealtimeHubSessionHandoffPolicyTests— passed (12 tests)/Applications/omi-tool-stall-reliability.appfromf9d5a81; health check confirmed the development backend and runtime protocol 2Failure-Class: none