Skip to content

chore(mcp): remediate Dependabot vulns#10130

Merged
skanderkaroui merged 2 commits into
mainfrom
fix/mcp-deps-bump
Jul 21, 2026
Merged

chore(mcp): remediate Dependabot vulns#10130
skanderkaroui merged 2 commits into
mainfrom
fix/mcp-deps-bump

Conversation

@undivisible

@undivisible undivisible commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Part of #7327.

Failure-Class: none

Review in cubic

@Git-on-my-level Git-on-my-level added dependency-review Touches dependencies or lockfiles; needs dependency review needs-maintainer-review Needs a human maintainer to sign off before merge labels Jul 20, 2026
@Git-on-my-level

Copy link
Copy Markdown
Collaborator

Thanks for the focused dependency remediation. I reviewed the changed MCP dependency files and this looks narrowly scoped: mcp/pyproject.toml only adds direct lower bounds for the packages being remediated, and mcp/uv.lock reflects the corresponding resolved versions (cryptography 49.0.0, pyjwt 2.13.0, python-multipart 0.0.32, starlette 1.3.1) with the mcp-server-omi lock metadata updated consistently.

I’m not formally approving because this touches dependency/lockfile security-sensitive surface and the current check state is not clean enough for an auto-approval path (several relevant repo checks are skipped/cancelled in the rollup). A human maintainer should confirm the Dependabot advisory targets and rerun/verify the applicable MCP/backend dependency checks before merge.

No obvious supply-chain red flags found in the diff itself.


by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with need human response.

@Git-on-my-level

Copy link
Copy Markdown
Collaborator

Dependency-remediation follow-up

This needs maintainer evidence before merge, rather than a blind resolver update:

  • Map each new direct lower bound (PyJWT, Starlette, cryptography, python-multipart) to the specific advisory and vulnerable dependency path it resolves.
  • Show a clean, reproducible MCP install/lock validation and the relevant MCP/backend test or smoke result on the PR head.
  • Keep this separate from fix(backend): remediate Dependabot vulns — 8 dependency bumps #10129: the uv.lock/MCP runtime surface has distinct resolution and release risks from the backend pip dependency wave.

No supply-chain red flag is alleged here; this is an evidence and compatibility gate for direct dependency policy.

@undivisible

Copy link
Copy Markdown
Collaborator Author

The requested MCP advisory mapping and reproducible MCP validation are not yet recorded on this PR, so it remains open for that dependency-specific evidence.

@kodjima33 kodjima33 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chore: dependabot vuln remediation (mcp) — approve only per policy

@skanderkaroui

Copy link
Copy Markdown
Collaborator

No test lane covers mcp, so CI skipping everything is expected and the checks passing is not coverage. Suggest running the mcp server once locally against uv.lock before merge as verification evidence.

- pyjwt 2.12.1 -> 2.13.0
- starlette 1.0.0 -> 1.3.1
- cryptography 48.0.0 -> 49.0.0
- python-multipart 0.0.29 -> 0.0.32

Adds direct dependency floors in pyproject.toml to pin safe
minimums for transitive deps from mcp[cli].

Failure-Class: none
Remove unused direct PyJWT/Starlette/cryptography/python-multipart
runtime deps. Keep safe minimums as tool.uv.constraint-dependencies so
mcp[cli] still resolves patched versions without policy-only directs.

Verification: uv lock; uv sync; uv run pytest -q (11 passed, 2 pre-existing fixture errors); uv run python -c import mcp_server_omi

Failure-Class: none
@skanderkaroui
skanderkaroui merged commit c207370 into main Jul 21, 2026
28 checks passed
@skanderkaroui
skanderkaroui deleted the fix/mcp-deps-bump branch July 21, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency-review Touches dependencies or lockfiles; needs dependency review needs-maintainer-review Needs a human maintainer to sign off before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants