chore(web/frontend): remediate Dependabot vulns#10132
Conversation
Git-on-my-level
left a comment
There was a problem hiding this comment.
Thanks for taking on the web/frontend dependency audit cleanup.
I can't accept this yet because the PR still leaves a high-severity brace-expansion audit finding in the full frontend dependency graph. I verified the current head with:
npm ci --ignore-scripts --no-audit --no-fund— installs successfullynpm test -- --test-reporter=spec— passes, 45 testsnpm audit --json— still reports 1 high vulnerability:brace-expansion/ GHSA-3jxr-9vmj-r5cpnpm audit --omit=dev --json— reports 0 production vulnerabilities
So the production-only audit is clean, but the PR title/body says Dependabot vulns are remediated and “Post-fix audit: 0 vulnerabilities”; that is not true for the normal npm audit path. Please either finish the remediation for the remaining dev dependency audit finding (the affected paths include brace-expansion under eslint/minimatch/glob/typescript-eslint paths) or narrow the PR description/validation to explicitly state that only production vulnerabilities are resolved.
No supply-chain red flags found in the package tarball URLs/integrities changed here; this is a completeness/validation blocker for a dependency-security PR.
by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with need human response.
fd54124 to
a6be46d
Compare
Follow-up completedRebased onto current
Fresh GitHub CI is now running. |
a6be46d to
f553b87
Compare
Git-on-my-level
left a comment
There was a problem hiding this comment.
Approved after the stale review finding was repaired, the branch was rebased, local preflight passed, independent gpt-5.6-terra review approved the exact rebased head, and fresh CI passed with clean full audit, tests, and lint.
Failure-Class: none
npm audit fixresolved all transitive vulnerabilities inweb/frontend