chore(omiGlass): remediate dependabot vulns#10134
Conversation
Git-on-my-level
left a comment
There was a problem hiding this comment.
Thanks for taking on the omiGlass dependency remediation. I think this needs another pass before merge.
Blocking issues I noticed:
@babel/coreis declared twice indevDependencies, and also moved into runtimedependencies. Babel is a build-time tool here, so this should stay indevDependenciesonly and be declared once.- The open range
>=7.26.0lets npm resolve Babel 8, and the lockfile currently does resolve@babel/core@8.0.1. Babel 8's package metadata requires Node^22.18.0 || >=24.11.0, which is a much narrower runtime than the existing React Native/Expo toolchain is likely expecting. If the goal is to remediate the Babel advisory while staying on Babel 7, please use a bounded range such as^7.26.0or>=7.26.0 <8and regenerate the lockfile. - Several vulnerability remediations are being forced by adding transitive packages (
shell-quote,tmp,undici,form-data,js-yaml,ws) as top-level dev dependencies. That can be acceptable when npm overrides are not available/desired, but this PR should validate that the resulting lockfile still installs and builds omiGlass. Right now the relevant CI jobs are skipped/cancelled, so we do not have a passing install/build signal for this dependency-sensitive change.
Could you please clean up the duplicate/misplaced dependency entries, avoid unintentionally upgrading into Babel 8 / Node 22.18+ requirements, regenerate the lockfile, and include the npm install/build or audit validation you used for omiGlass?
I am marking this for dependency review and tests before maintainer merge consideration.
by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with need human response.
|
Kept Babel dev-only and bounded to v7 in ecb9929; the regenerated lockfile passes clean install and audit validation. |
kodjima33
left a comment
There was a problem hiding this comment.
Chore: dependabot vuln remediation (omiGlass) — approve only per policy
ecb9929 to
10bea1c
Compare
|
Heads up: there is no CI lane for omiGlass, so the green checks here mean nothing ran, not that the upgrade was tested. Worth a quick local build or expo start before merging given package.json changed, not just the lockfile. |
10bea1c to
15e933a
Compare
Part of #7327. Failure-Class: none