Skip to content

fix(macos): make signed smoke entitlements temp file unique#10187

Closed
Git-on-my-level wants to merge 1 commit into
mainfrom
fix/signed-smoke-mktemp
Closed

fix(macos): make signed smoke entitlements temp file unique#10187
Git-on-my-level wants to merge 1 commit into
mainfrom
fix/signed-smoke-mktemp

Conversation

@Git-on-my-level

@Git-on-my-level Git-on-my-level commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix the signed-artifact smoke entitlements mktemp template so BSD mktemp substitutes a trailing XXXXXX sequence.
  • Add a hermetic regression test that invokes the production template twice and requires distinct files.

Product invariants affected

  • INV-AUTH-1

Failure-Class

Failure-Class: none

Verification

  • RED: cd desktop/macos && bash tests/test-signed-artifact-smoke.sh failed before the fix with mktemp: mkstemp failed on .../omi-entitlements.XXXXXX.plist: File exists.
  • GREEN: cd desktop/macos && bash tests/test-signed-artifact-smoke.sh
  • cd desktop/macos && bash -n scripts/smoke-signed-desktop-artifact.sh && bash -n tests/test-signed-artifact-smoke.sh && python3 scripts/check_desktop_test_quality.py
  • python3 .github/scripts/check-release-process-guards.py
  • python3 .github/scripts/test_check_desktop_auto_beta_candidate.py

Review in cubic

@Git-on-my-level

Copy link
Copy Markdown
Collaborator Author

Closing as redundant: #10185 already merged the broader portable mktemp-template fix and its regression coverage. Keeping a second conflicting smoke fix would duplicate the release lane.

@github-actions

Copy link
Copy Markdown
Contributor

Hey @Git-on-my-level 👋

Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request.

After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:

  • Project standards — Ensuring consistency across the codebase
  • User needs — Making sure changes align with what our users need
  • Code best practices — Maintaining code quality and maintainability
  • Project direction — Keeping aligned with our product principles and locked invariants

Before your next PR, please skim:

  • PRODUCT.md — product north star
  • Product invariants — locked rules (shared chat, memory tiers, agent control plane, integrations, brand)

If this was declined for direction or taste, maintainers should cite an invariant ID or open a proposed one — ask if that citation is missing.

Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out.

Thank you for being part of the Omi community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant