fix(macos): make signed smoke entitlements temp file unique#10187
fix(macos): make signed smoke entitlements temp file unique#10187Git-on-my-level wants to merge 1 commit into
Conversation
|
Closing as redundant: #10185 already merged the broader portable mktemp-template fix and its regression coverage. Keeping a second conflicting smoke fix would duplicate the release lane. |
|
Hey @Git-on-my-level 👋 Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request. After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:
Before your next PR, please skim:
If this was declined for direction or taste, maintainers should cite an invariant ID or open a proposed one — ask if that citation is missing. Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out. Thank you for being part of the Omi community! |
Summary
mktemptemplate so BSDmktempsubstitutes a trailingXXXXXXsequence.Product invariants affected
Failure-Class
Failure-Class: none
Verification
cd desktop/macos && bash tests/test-signed-artifact-smoke.shfailed before the fix withmktemp: mkstemp failed on .../omi-entitlements.XXXXXX.plist: File exists.cd desktop/macos && bash tests/test-signed-artifact-smoke.shcd desktop/macos && bash -n scripts/smoke-signed-desktop-artifact.sh && bash -n tests/test-signed-artifact-smoke.sh && python3 scripts/check_desktop_test_quality.pypython3 .github/scripts/check-release-process-guards.pypython3 .github/scripts/test_check_desktop_auto_beta_candidate.py