feat(chat): add mobile date, time, and city context across AI routes#10618
feat(chat): add mobile date, time, and city context across AI routes#10618undivisible wants to merge 5 commits into
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Updated the title and description to explicitly cover live date, time, timezone, and city-level context. Focused backend tests pass: prompt cache (32), async offload (14), and geocoding cache (16). |
Verification: backend prompt-cache, async-offload, and geocoding unit tests; backend typecheck.
8a93ba7 to
dedb29d
Compare
Failure-Class: none Verification: BACKEND_UNIT_TEST_FILE_LIST=/tmp/omi-backend-unit-failures.txt bash backend/test.sh; python3 .github/scripts/check-release-process-guards.py.
|
Fixed the stale qualification-checkout guard; the release-script test (30 passed) and release guard now pass locally. |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Git-on-my-level
left a comment
There was a problem hiding this comment.
Thanks for tightening this up — the direction of keeping time/city metadata out of the cached system prompt and passing only city-level location looks sensible.
I found one blocking issue before this can merge:
backend/tests/unit/test_prompt_cache_integration.py::test_current_datetime_block_includes_city_without_coordinatescurrently expectsCurrent city-level location: New York, New York, United States, butget_current_datetime_block()emitsRecent city-level location: .... That mismatch explains the failing Backend unit suite on this head; please align the implementation/test wording and rerun the focused backend tests.
I also left workflow-review on this because the PR touches the desktop release guard expectations in addition to the chat prompt path. Human maintainer review is still needed before merge for the product/privacy implications of adding live city context to chat prompts and for the workflow-sensitive release guard change.
by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with need human response.
Failure-Class: none
Summary
Verification
backend/.venv/bin/python -m pytest -q tests/unit/test_chat_async_offload.py tests/unit/test_prompt_metadata_safety.py tests/unit/test_city_prompt_context.py tests/unit/test_geocoding_cache.pybackend/scripts/typecheck.shscripts/openapi_runner.sh scripts/export_openapi.py --surface public --write ../docs/api-reference/openapi.jsonFailure class
Failure-Class: none