Skip to content

Fix example pubspec constraints and bump to 2.1.1 - #48

Merged
rickdijk merged 2 commits into
mainfrom
rick/fpl-31-octo_image-example-pubspec-excludes-every-sdk-the-package
Sep 23, 2026
Merged

rickdijk merged 2 commits into
mainfrom
rick/fpl-31-octo_image-example-pubspec-excludes-every-sdk-the-package

Conversation

@rickdijk

@rickdijk rickdijk commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix.

⤵️ What is the current behavior?

example/pubspec.yaml declares environment: sdk: ">=2.12.0-0 <3.0.0", which does not overlap with the package's own >=3.0.0 <4.0.0. The example depends on octo_image by path, so no SDK the package supports satisfies the example's own constraint. flutter_lints in the example is also stuck at ^1.0.4 against the package's ^4.0.0.

🆕 What is the new behavior (if this is a feature change)?

  • example/pubspec.yaml's environment.sdk now matches the package (>=3.0.0 <4.0.0), with a matching flutter: '>=3.10.0' lower bound added.
  • flutter_lints in the example bumped to ^4.0.0 to match the package.
  • That bump surfaces four use_super_parameters findings in example/lib (Key? key constructors) that fail flutter analyze at the repo root under the newer lint set; converted those four constructors to super.key.
  • http stays as a dependency: example/lib/helpers/mock_image_provider.dart imports it and is reachable from main_sets.dart, an alternate example entry point not wired into main.dart, so it isn't unused.

Bumps the version to 2.1.1 with a changelog entry covering everything merged since 2.1.0, so main is ready to tag. Nothing under lib/ changed; the user-visible fix is the README, whose published copy still shows a dead CI badge and a demo image linked from a removed branch.

💥 Does this PR introduce a breaking change?

No.

🐛 Recommendations for testing

  • cd example && flutter pub get resolves cleanly.
  • flutter analyze at the repo root reports no issues.
  • flutter build macos --release (or another platform) succeeds from example/.

📝 Links to relevant issues/docs

https://linear.app/baseflowit/issue/FPL-31/octo-image-example-pubspec-excludes-every-sdk-the-package-supports

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated
  • Rebased onto current main
  • Version bumped in pubspec.yaml and dated CHANGELOG.md entry added (skip for docs-only and CI-only changes)

🤖 Generated with Claude Code

example/pubspec.yaml declared sdk: ">=2.12.0-0 <3.0.0", which does not
overlap with the package's own >=3.0.0 <4.0.0. Since the example depends
on octo_image by path, no SDK the package supports satisfied the
example's own constraint. Align sdk, add the matching flutter lower
bound, and bump flutter_lints to ^4.0.0 to match the package's dev
dependency.

The flutter_lints bump surfaces four pre-existing use_super_parameters
findings in example/lib (Key? key : super(key: key)), which now fail
`flutter analyze` at the repo root since flutter_lints 1.0.4 predates
that lint. Convert those four constructors to super.key to keep analyze
green.

http stays as a dependency: example/lib/helpers/mock_image_provider.dart
imports it and is reachable from main_sets.dart, an alternate example
entry point not wired into main.dart.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@rickdijk
rickdijk changed the base branch from develop to main September 23, 2026 18:49
Covers everything merged since v2.1.0 so main is ready to tag. Nothing
under lib/ changed; the user-visible fix is the README, whose published
copy on pub.dev still shows a dead CI badge and a demo image linked from
a branch that no longer exists.

Co-Authored-By: Claude <noreply@anthropic.com>
@rickdijk rickdijk changed the title Fix example pubspec SDK/lint constraints to match the package Fix example pubspec constraints and bump to 2.1.1 Sep 23, 2026
@rickdijk
rickdijk merged commit 60247d2 into main Sep 23, 2026
10 checks passed
@rickdijk
rickdijk deleted the rick/fpl-31-octo_image-example-pubspec-excludes-every-sdk-the-package branch September 23, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant