Repository navigation
Conversation
example/pubspec.yaml declared sdk: ">=2.12.0-0 <3.0.0", which does not overlap with the package's own >=3.0.0 <4.0.0. Since the example depends on octo_image by path, no SDK the package supports satisfied the example's own constraint. Align sdk, add the matching flutter lower bound, and bump flutter_lints to ^4.0.0 to match the package's dev dependency. The flutter_lints bump surfaces four pre-existing use_super_parameters findings in example/lib (Key? key : super(key: key)), which now fail `flutter analyze` at the repo root since flutter_lints 1.0.4 predates that lint. Convert those four constructors to super.key to keep analyze green. http stays as a dependency: example/lib/helpers/mock_image_provider.dart imports it and is reachable from main_sets.dart, an alternate example entry point not wired into main.dart. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Covers everything merged since v2.1.0 so main is ready to tag. Nothing under lib/ changed; the user-visible fix is the README, whose published copy on pub.dev still shows a dead CI badge and a demo image linked from a branch that no longer exists. Co-Authored-By: Claude <noreply@anthropic.com>
rickdijk
deleted the
rick/fpl-31-octo_image-example-pubspec-excludes-every-sdk-the-package
branch
September 23, 2026 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix.
example/pubspec.yamldeclaresenvironment: sdk: ">=2.12.0-0 <3.0.0", which does not overlap with the package's own>=3.0.0 <4.0.0. The example depends onocto_imageby path, so no SDK the package supports satisfies the example's own constraint.flutter_lintsin the example is also stuck at^1.0.4against the package's^4.0.0.🆕 What is the new behavior (if this is a feature change)?
example/pubspec.yaml'senvironment.sdknow matches the package (>=3.0.0 <4.0.0), with a matchingflutter: '>=3.10.0'lower bound added.flutter_lintsin the example bumped to^4.0.0to match the package.use_super_parametersfindings inexample/lib(Key? keyconstructors) that failflutter analyzeat the repo root under the newer lint set; converted those four constructors tosuper.key.httpstays as a dependency:example/lib/helpers/mock_image_provider.dartimports it and is reachable frommain_sets.dart, an alternate example entry point not wired intomain.dart, so it isn't unused.Bumps the version to 2.1.1 with a changelog entry covering everything merged since 2.1.0, so
mainis ready to tag. Nothing underlib/changed; the user-visible fix is the README, whose published copy still shows a dead CI badge and a demo image linked from a removed branch.💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
cd example && flutter pub getresolves cleanly.flutter analyzeat the repo root reports no issues.flutter build macos --release(or another platform) succeeds fromexample/.📝 Links to relevant issues/docs
https://linear.app/baseflowit/issue/FPL-31/octo-image-example-pubspec-excludes-every-sdk-the-package-supports
🤔 Checklist before submitting
🤖 Generated with Claude Code