Add Linux AppImage generation support#215
Conversation
In Startup.cpp, disable name checking if running from inside AppImage Added AppImage.cmake to generate AppDir and AppImage Includes icon (required for AppImage)
|
Sorry for the delay. That's waay too big of a file. I think the standard icon sizes for appImages go up to 1024x1024. |
|
@jstefanelli Thanks for this PR! Friend on mine is on Linux, cant compile this project because of some weird error that neither of us cant figure out, so an AppImage would be really nice to have. Do you have some basic build instructions for your branch? I would like to test this and build an AppImage for my friend, and while im at it review the PR. |
|
Hi @ToasterUwU, the build instructions are almost the same as usual. For the AppImage you need 2 things: make sure |
Could you send this error? If it doesn't compile normally I doubt it will work as an AppImage. |
|
@WiserTixx I'm not familira with GH, I may have hit "resolve conversation" too soon, thought it was a me only thing. Apologies. |
|
@jstefanelli So i did everything you described i should do, but i get an error that the target I have no prior experience with cmake, so i dont know if its normal that "gmake" is complaining to me instead of cmake, when i ran cmake. So its either user error, or the target actually doesnt exist. |
|
I looked over the changed files, and i cant really see anything that would add this extra target, but like i said, no prior experience. |
|
@ToasterUwU |
|
Mhh interesting. Then it doesn't find it, even tho it is in PATH Had to do it temporarily in PATH with a wrapper script since appimagetool only exists as an appimage it seems. |
https://github.com/gabriele2000/scripts-collection/blob/main/beammp-autoinstall.sh |
|
Any update on this? |
Adds optional AppImage generation via
appimagetoolon Linux.Only 1 code change was necessary to make AppImage work:
In Startup.cpp, disable name checking if running from inside AppImage
Other changes are:
Added
AppImage.cmaketo generate AppDir and AppImageIncludes icon (required for AppImage)
The target to generate the AppImage (which is not build by default) is
Launcher_AppImage, and it generates the fileLauncher.AppImagein the build directoryBy creating this pull request, I understand that code that is AI generated or otherwise automatically generated may be rejected without further discussion.
I declare that I fully understand all code I pushed into this PR, and wrote all this code myself and own the rights to this code.