Skip to content

Conversation

@abanuelo
Copy link
Contributor

Description

For this fix, I noticed that when if we use pyglet>=1.5.28 in our pyproject.toml it will use default to shutting down the generated Scenario immediately after the .show() is called to render the trimesh Scene. To resolve this I played with installing earlier versions of pyglet and landed on 1.5.26 as a good alternative to allow us to create multiple scenarios on Apple silicon devices, as is the expected behavior. Below is a video illustrating the fix:

fixed-230.mov

Issue Link

#230

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo requested review from Eric-Vin and dfremont April 25, 2024 19:47
@codecov
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.11%. Comparing base (747f211) to head (030c288).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   86.15%   86.11%   -0.05%     
==========================================
  Files         144      144              
  Lines       24949    24984      +35     
==========================================
+ Hits        21494    21514      +20     
- Misses       3455     3470      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Eric-Vin
Copy link
Collaborator

Hmm, I'm hesitant to pin a specific version since we might block downstream users who are using Scenic as a library. Is this a bug fix where we can set a floor instead?

@abanuelo
Copy link
Contributor Author

@dfremont and I discussed the proposed fix in this PR and he suggested we make the cieling for pyglet 1.5.26 but if trimesh does upgrade its library to support >2.0 pyglet we can adjust accordingly.

@lola831
Copy link
Collaborator

lola831 commented Mar 19, 2025

With PR #330 now updating our pyglet dependency to allow version 2.0.18—which fixes the Apple Silicon window termination issue—we no longer need these workarounds.

@dfremont dfremont deleted the abanuelo/fix-230 branch April 8, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants