Skip to content

Conversation

@lola831
Copy link
Collaborator

@lola831 lola831 commented Sep 18, 2025

Description

Implements the missing driving domain actions in the MetaDrive interface (SetPositionAction, SetVelocityAction, SetHandBrakeAction, SetReverseAction) and makes control inputs persist until changed (as Scenic intends).

Issue Link

Issue 386

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

N/A

@lola831 lola831 requested a review from dfremont September 18, 2025 21:22
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.94%. Comparing base (d76f367) to head (827e79b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
+ Coverage   89.90%   89.94%   +0.03%     
==========================================
  Files          54       54              
  Lines       13560    13562       +2     
==========================================
+ Hits        12191    12198       +7     
+ Misses       1369     1364       -5     
Files with missing lines Coverage Δ
src/scenic/domains/driving/actions.py 84.80% <ø> (+1.59%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple minor comments.

@lola831 lola831 requested a review from dfremont November 18, 2025 00:19
Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Lola!

@lola831 lola831 requested a review from dfremont December 12, 2025 01:22
@dfremont dfremont merged commit f0e3e60 into BerkeleyLearnVerify:main Dec 12, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants