-
Notifications
You must be signed in to change notification settings - Fork 135
Implement missing driving domain actions in MetaDrive interface #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
==========================================
+ Coverage 89.90% 89.94% +0.03%
==========================================
Files 54 54
Lines 13560 13562 +2
==========================================
+ Hits 12191 12198 +7
+ Misses 1369 1364 -5
🚀 New features to boost your workflow:
|
dfremont
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple minor comments.
dfremont
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Lola!
Description
Implements the missing driving domain actions in the MetaDrive interface (
SetPositionAction,SetVelocityAction,SetHandBrakeAction,SetReverseAction) and makes control inputs persist until changed (as Scenic intends).Issue Link
Issue 386
Checklist
pytestand/or other meansAdditional Notes
N/A