Skip to content

Conversation

@lola831
Copy link
Collaborator

@lola831 lola831 commented Nov 24, 2025

Description

This PR updates calculateFilmSize to clamp the map width/height to a minimum extent
before converting to pixels. When a SUMO convBoundary has zero extent in either
dimension (e.g., a straight road where width or height is 0), we would previously
compute a film size with a zero dimension, causing the 2D MetaDrive render to appear
blank. Clamping avoids this and keeps top-down rendering working for such maps.

Issue Link

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@lola831 lola831 requested review from Eric-Vin and dfremont November 24, 2025 19:24
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.98%. Comparing base (e093379) to head (57838af).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   89.86%   89.98%   +0.11%     
==========================================
  Files          54       54              
  Lines       13549    13556       +7     
==========================================
+ Hits        12176    12198      +22     
+ Misses       1373     1358      -15     

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Eric-Vin Eric-Vin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, and confirmed to fix the issue we were experiencing. Thanks!

@Eric-Vin Eric-Vin merged commit 54cfcbb into BerkeleyLearnVerify:main Nov 26, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants