Fix MetaDrive film size for straight SUMO maps #423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
calculateFilmSizeto clamp the map width/height to a minimum extentbefore converting to pixels. When a SUMO
convBoundaryhas zero extent in eitherdimension (e.g., a straight road where width or height is 0), we would previously
compute a film size with a zero dimension, causing the 2D MetaDrive render to appear
blank. Clamping avoids this and keeps top-down rendering working for such maps.
Issue Link
Checklist
pytestand/or other meansAdditional Notes