-
Notifications
You must be signed in to change notification settings - Fork 135
Include map options in road network cache #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
==========================================
+ Coverage 89.93% 90.04% +0.11%
==========================================
Files 54 54
Lines 13562 13585 +23
==========================================
+ Hits 12197 12233 +36
+ Misses 1365 1352 -13
🚀 New features to boost your workflow:
|
| """Changing map options should invalidate and rewrite the cached .snet file.""" | ||
| # Get the temp copy of Town01 from cached_maps. | ||
| xodr_loc = cached_maps[str(mapFolder / "CARLA" / "Town01.xodr")] | ||
| xodr_path = Path(str(xodr_loc)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a future PR: we should switch from tmpdir_factory to tmp_path_factory so that we already have Path objects and don't need to do this conversion.
dfremont
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great -- just one very minor change and a suggestion for later. Also we'll need to fix the merge conflicts.
Description
This PR makes the
.snetcache also depend on map options.I added a new
deterministicHashhelper and use it for both map options and scene serialization (CompileOptions.hash).Since the scene options hash changed, I bumped the scene format version to 3.
Issue Link
#393
Checklist
pytestand/or other meansAdditional Notes
N/A