Skip to content

Conversation

@dfremont
Copy link
Collaborator

Description

Fixes the sensors example so that it works with pytest examples (I had forgotten to specify it needs to run in 2D mode), and adds better error messages if you try to run a driving domain scenario with sensors under a simulator that doesn't support them. I also removed the CARLA-specific version of the sensors example since it was nearly identical to the driving domain version, which works in CARLA anyway.

Issue Link

n/a

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@lola831 could you please try the sensors example out in CARLA? I've tested it in MetaDrive and the Newtonian simulator (the latter triggering the new error message), but you can try those too.

@dfremont dfremont requested a review from lola831 December 17, 2025 19:30
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.89%. Comparing base (94c55d8) to head (c46e5c5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   90.01%   89.89%   -0.12%     
==========================================
  Files          54       54              
  Lines       13580    13578       -2     
==========================================
- Hits        12224    12206      -18     
- Misses       1356     1372      +16     

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@lola831 lola831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI now passes with the latest changes. Also tested locally (including running the sensors example in CARLA).

@lola831 lola831 merged commit 8a2081a into main Dec 18, 2025
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants