Compile project on Java 11, build on 11, 17, 21 #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bryancross ,
I've just found your library and it eases the work for my team. I would like to do some contributions if You accept.
First of all, I think it would be good if JPostman could be used with lower Java versions than 18.
I made some small changes to enable the compilation of JPostman with Java 11 (Java 8 compatibility can be achieved if we use something other than java.net.http.HttpClient).
I've modified the build file to build the application with JDK 11, 17, 21, just to make sure it's working with these.
You can see the output of the job in my forked repository here or here is the snapshot build, but I do not have the Postman API key. That's why some of the tests fail, but it should work on your repository.
After this PR, I would like to work on the Maven Central publishing to be able to access JPostman as Maven dependency.