cp-159: Add more steps to the survey#159 #319
Conversation
…age container style
BrianSammit
changed the title
| void handleSubmit(handleSurveySubmit)(); | ||
| }, [handleSubmit, handleSurveySubmit]); | ||
| const handleBack = (): void => { | ||
| navigation.navigate(SurveyScreenName.MEDITATION_EXPERIENCE); |
There was a problem hiding this comment.
Each step has lots of similarities with others, at least I can see only another navigation route is a difference. There's no reason to duplicate so much code, so I think you can create a wrapper, which will contain all this logic with parent route /survey, and then change only the questions according to the children route, like /survey/preferences-step
There was a problem hiding this comment.
I will check that the problem with the route approach is that React Native does not use a route as in React. React Native uses stacks. But you're right I will find a way to not use the same code in the steps.
v0ldemar01
left a comment
v0ldemar01
left a comment
There was a problem hiding this comment.
Also please contact to Oscar to be in touch with current changes
| void dispatch( | ||
| authActions.createUserSurvey({ | ||
| userId: userId, | ||
| journaling_experience: [], |
| [SurveyScreenName.PREFERENCES]: undefined | object; | ||
| [SurveyScreenName.FEELINGS]: undefined | object; | ||
| [SurveyScreenName.GOALS]: undefined | object; | ||
| [SurveyScreenName.WORRIES]: undefined | object; | ||
| [SurveyScreenName.MEDITATION_EXPERIENCE]: undefined | object; | ||
| [SurveyScreenName.JOURNALING_EXPERIENCE]: undefined | object; |
There was a problem hiding this comment.
Provide more specific types
There was a problem hiding this comment.
Create a generic component for reusing, it is not a good practise of your approach
mobile/src/screens/survey/survey.tsx
Outdated
| const [preferencesSurvey, setPreferencesSurvey] = useState([]); | ||
| const [feelingsSurvey, setFeelingsSurvey] = useState([]); | ||
| const [goalsSurvey, setGoalsSurvey] = useState([]); | ||
| const [worriesSurvey, setWorriesSurvey] = useState([]); | ||
| const [meditationSurvey, setMeditationSurvey] = useState([]); |
mobile/src/screens/survey/survey.tsx
Outdated
| feelings: feelingsSurvey, | ||
| goals: goalsSurvey, | ||
| worries: worriesSurvey, | ||
| meditation_experience: meditationSurvey, |
iamAlinaaa
left a comment
iamAlinaaa
left a comment
There was a problem hiding this comment.
We already have fonts in our mobile app, please add fonts everywhere where necessary
…m/BinaryStudioAcademy/bsa-2023-calmpal into task/cp-159-add-more-steps-survey
…bsa-2023-calmpal into task/cp-159-add-more-steps-survey
I'm waiting for the back-end part #156 to test the proper save in the database