cp-503: Mobile Delete Note And Card Improvement #512
+41
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamAlinaaa
requested review from
fshabanov,
liza-veis,
v0ldemar01 and
what1s1ove
as code owners
v0ldemar01
requested changes
Sep 30, 2023
| id, | ||
| isModalVisible, | ||
| }) => { | ||
| const handleSwipeableReference = useCallback( |
Collaborator
There was a problem hiding this comment.
Can we prefer using useRef with array without Map outside?
OlesiaTr
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After user slides for deleting an option, once he/she clicks somewhere else on the screen, the option becomes not in 'delete' state and when another card is swiped previos one is swiped back so delete option is available only for one card at a time
Android.Emulator.-.Pixel_7_Pro_API_33_5554.2023-09-30.11-21-01.mp4