cp-434: Added Open Ai errors #513
Open
+69
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Nanaier
commented
Sep 30, 2023
Nanaier
commented
Nanaier
requested review from
fshabanov,
liza-veis,
v0ldemar01 and
what1s1ove
as code owners
liza-veis
requested changes
Sep 30, 2023
| message: response.statusText, | ||
| }; | ||
| } | ||
| private handleError(response: Response): Promise<never> { |
Collaborator
There was a problem hiding this comment.
we also need to catch and rethrow error in service, because we need to override status code, for example if open ai respond with 401, we don't want to respond with 401 because user will be signed out
dmytro-kucherenko
previously approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.