cp-363: Scroll to selected chat after reloading #516
+39
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytro-kucherenko
requested review from
fshabanov,
liza-veis,
v0ldemar01 and
what1s1ove
as code owners
HIMDanny
reviewed
Sep 30, 2023
Comment on lines
+63
to
+67
| useEffect(() => { | ||
| if (chatsDataStatus === DataStatus.FULFILLED) { | ||
| setIsChatsLoaded(true); | ||
| } | ||
| }, [chatsDataStatus, setIsChatsLoaded]); |
Collaborator
There was a problem hiding this comment.
why do we need a state for this? Can't we simply check like this?
const isChatsLoaded = chatsDataStatus === DataStatus.FULFILLED
Collaborator
Author
There was a problem hiding this comment.
@HIMDanny We can't. Scroll to the selected card should be only on first chats loading, because then data status will change on every search request
Collaborator
There was a problem hiding this comment.
now I see, thanks for clarification
Collaborator
There was a problem hiding this comment.
btw, we also can use ref for this to not cause a rerender after setIsChatLoaded(true)
Collaborator
Author
There was a problem hiding this comment.
@HIMDanny What do you mean by saying use ref?
Collaborator
There was a problem hiding this comment.
nevermind, now I am not sure whether it will work)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done:
2023-09-30.13-16-42.mp4