-
Notifications
You must be signed in to change notification settings - Fork 25
WIP: Add .bcif
support
#71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
BradyAJohnston
wants to merge
25
commits into
BioJulia:master
Choose a base branch
from
BradyAJohnston:bcif
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 11 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
cf71a8f
initial working BCIF decoding
BradyAJohnston 8bdb53f
turn into `read()` function
BradyAJohnston a7defb2
cleanup
BradyAJohnston 7367a76
cleanup
BradyAJohnston c0911d7
run JuliaFormatter
BradyAJohnston 0886b58
cleanup and multithread column decoding
BradyAJohnston c427d66
Return as MolecularStructure
BradyAJohnston 070fd36
entire datablock to dict
BradyAJohnston c1ee984
cleanup
BradyAJohnston 9fb8b7b
cleanup
BradyAJohnston 88d6940
add download and cleanup
BradyAJohnston 6ffcbfc
Merge branch 'master' into bcif
BradyAJohnston 4f191cc
Revert "add download and cleanup"
BradyAJohnston 137186b
BCIF support for downloading
BradyAJohnston 1bdf0fc
format
BradyAJohnston b168125
fix downloading
BradyAJohnston f91a94a
parsing working again
BradyAJohnston cd08209
fix parsing of multi-model files
BradyAJohnston df0a03d
initial test comparison
BradyAJohnston 5421031
remove extra type lookups and conversions
BradyAJohnston 8270f08
incorporate most feedback
BradyAJohnston 244a6a0
Update src/bcif.jl
BradyAJohnston 622f4b7
remove 1BNA
BradyAJohnston 512bb8b
Merge branch 'bcif' of github.com:BradyAJohnston/BioStructures.jl int…
BradyAJohnston 080ad27
make structs immutable
BradyAJohnston File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to know how much time this adds to
using BioStructures
. I expect not a lot, but it can be put in an extension if it is significant.