backend: add eth account to software keystore. #3329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for Ethereum accounts within the software keystore, allowing ETH transactions to be signed along with existing BTC support.
- Added the Ethereum coin import and updated type switches in SupportsCoin and SupportsAccount.
- Introduced a dedicated signETHTransaction function and refactored SignTransaction to handle both BTC and ETH transaction proposals.
Comments suppressed due to low confidence (2)
backend/keystore/software/software.go:270
- The alias 'ethTypes' is referenced here but is not imported. Please update the import or alias usage to match the correct package name for Ethereum types.
tx.Tx, err = ethTypes.SignTx(tx.Tx, tx.Signer, privKey.ToECDSA())
backend/keystore/software/software.go:284
- [nitpick] Consider returning an error instead of panicking in the default case of SignTransaction to improve fault tolerance in production scenarios.
panic("unknown proposal type")
bznein
commented
May 7, 2025
Comment on lines
+261
to
+272
| func (keystore *Keystore) signETHTransaction(tx *eth.TxProposal) error { | ||
| xprv, err := tx.Keypath.Derive(keystore.master) | ||
| if err != nil { | ||
| return errp.Newf("failed to derive key: %v", err) | ||
| } | ||
| privKey, err := xprv.ECPrivKey() | ||
| if err != nil { | ||
| return errp.Newf("failed to get private key: %v", err) | ||
| } | ||
| tx.Tx, err = ethTypes.SignTx(tx.Tx, tx.Signer, privKey.ToECDSA()) | ||
| return err | ||
| } |
There was a problem hiding this comment.
I don't know how correct this is :) It works, but it was mostly a result of try-and-error, copy-paste, and ChatGPT :)
Open to feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this addition, we can use ETH accounts in a software keystore. As shown in the screenshot, accounts can be added, and they can correctly receive/send/send-to-self:
Before asking for reviews, here is a check list of the most common things you might need to consider: