Atomic #122
Merged
Atomic #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better clarity and composes better with generic functions returning a single value.
NickeZ
reviewed
May 2, 2025
NickeZ
reviewed
May 2, 2025
NickeZ
reviewed
May 2, 2025
Some API calls, like BTCSign, or BluetoothUpgrade, require a series of request<>response pairs. If the device gets an unexpected message, it fails. However, this is not concurrency safe - if another goroutine sends something in the middle of it, the API call in progress and the interrupting call both fail. To solve this, we introduce `apiLock` that ensures a series of queries does not get interrupted. Most API functions only use a single query, so we acquire this lock by default in `.query()`. We add a `nonAtomicQuery()` variant with a `atomicQueries()` helper function to enable making a series of calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.